Tests: Ignore .github directories in package test #5098
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
JKLeckr
force-pushed
the
dev
branch
2 times, most recently
from
1117721 to
66ca041
Compare
JKLeckr
changed the title
Exempt-Medic
added
is: bug/fix
JKLeckr
force-pushed
the
dev
branch
2 times, most recently
from
b34d012 to
f638053
Compare
qwint
reviewed
Jun 20, 2025
| worlds_path = Utils.local_path("worlds") | ||
| for dirpath, dirnames, filenames in os.walk(worlds_path): | ||
| dirnames[:] = [d for d in dirnames if d not in ignore_dirs] |
There was a problem hiding this comment.
this could probably use a comment as it's not obvious that it's modifying the list used in the walk generator
There was a problem hiding this comment.
Y'know. Ironically, I was taking a lot of time contemplating whether the comments were necessary or not since I did not see much existing comments in this code.
I added comments.
Added comments for ignore code
qwint
approved these changes
Jun 21, 2025
qwint
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
What is this?
The package test now ignores .github directories (can be changed to exclude more or less directories).
Why is it needed?
There are some APWorlds that use python scripts for GitHub Actions (contained in .github), but then doing so would fail the unit tests.
There is always adding an
__init__.pyin there, but then python would treat the .github directory as a module, which isn't always the desired behavior.How was this tested?
Ran the Unit Tests with and without python scripts in the .github directories, and tested to see if it still caught .py scripts without
__init__.pyin other directories.