Skip to content

Core: changes template yaml formatting for option group separators #5092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Core: changes template yaml formatting for option group separators #5092

wants to merge 2 commits into from
+3 −1

Conversation

qwint
Copy link
Collaborator

@qwint qwint commented Jun 9, 2025

What is this fixing or adding?

adds more formatting to option group headers in template yamls

How was this tested?

generated templates

If this makes graphical changes, please attach screenshots.

image
image

@qwint qwint added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 9, 2025
Emerassi
Emerassi approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@Emerassi Emerassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improving the visibility of the option groups in the yaml is a win in my opinion. The way you chose to do it looks low risk and is a marked improvement. I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emerassi Emerassi Emerassi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwint @Emerassi