Tests: add a state attribute to WorldTestBase #5090
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwint
added
is: enhancement
Emerassi
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Now I know what you meant in apworld-dev when you said we should be making a new state instead of referencing multiworld.state. Your proposed change here looks like it will make it easier to achieve your goal of getting people not to use multiworld.state so it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Just adds a state attribute to WorldTestBase for world tests to use. Unfortunately can't swap all the methods to use it because of how many worlds currently use only some of the helper methods while not using others and using multiworld.state directly for some reason
How was this tested?
Ran tests