Skip to content

Fill: Fix remaining_fill + move_unplaceable_to_start_inventory #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Exempt-Medic
Copy link
Member

What is this fixing or adding?

last_batch was completely unused, and fill tried to place unplaceable items, again. Now it actually uses the filler items instead and clears out unplaced_items so that they aren't reported as item/location inequality miscounts.

How was this tested?

Two-player generations with a lot of filler in local_items.

@github-actions github-actions bot added the affects: core Issues/PRs that touch core and may need additional validation. label Jun 7, 2025
@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 7, 2025
Copy link
Collaborator

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a code review perspective the changes make sense to what the surrounding code is attempting to do and are minimal
tested in action with the following lingo yaml(s) and on seed 96057042239188917743 (and others but wanted to prove it wasn't a randomness fluke), it crashes gen without this change and generates fine with,

name: Player{number}
game: Lingo
Lingo:
  trap_percentage: 100
  trap_weights:
    Atbash Trap: 1
  non_local_items:
    [Atbash Trap]
---
name: Player{number}
game: Lingo
Lingo:
  trap_percentage: 100
  trap_weights:
    Atbash Trap: 1
  non_local_items:
    [Atbash Trap]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants