Add fallback to previous version feature for s3 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
sneako
reviewed
May 13, 2025
sneako
reviewed
May 13, 2025
sneako
reviewed
May 13, 2025
| version_id: state.version_id | ||
| ) | ||
|
|
||
| versions = if state.versions, do: {:ok, state.versions}, else: list_object_versions(state) |
There was a problem hiding this comment.
I'm not 100% sure how s3 replication works, are the versions guaranteed to be the same across replicated buckets? If not, then it is possible we have stored the versions of one region, and now are trying a fallback region with the original versions
There was a problem hiding this comment.
Hmm but if the bucket fails and it chooses the failover bucket then the list_object_versions will be called to the failover bucket, so the versions it gets will be from the new bucket.
but yea I see what you're saying, in the edge case that the version fails to deserialise and then the bucket fails midway ? Seems quite unlikely but I guess could happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by mrge
Added a fallback feature for S3 fetches that tries previous object versions if deserialization fails.
version_fallback?option to enable automatic fallback to older S3 object versions.previous_version/1for S3 fetcher to retrieve earlier versions.