Skip to content

Conversation

vikanezrimaya
Copy link

@vikanezrimaya vikanezrimaya commented Nov 10, 2018

Related Issue
Was discussed in email with repo owner. [Angelo: Issue #40 opened to track this]

Issue mentioned in post: https://fireburn.ru/post/why-my-site-looks-as-it-does/

Dependency Changes
Added jQuery. Can be removed if someone bothers to port comment section in single.html to vanilla JS.

Testing

  • Built and tested to work on a standalone Hugo site
  • Built and tested to work in the Hugo Theme Gallery demo site (link)
  • Tested with browser's responsive-design tools
  • Tested in production

Additional context
Like buttons are not included because:

  1. More JS would be needed (one JS per post)
  2. The design is not polished yet

Add configuration for endpoints.
This thing needs jQuery. Probably can be simplified to not include it.
This could probably get removed if I port comment section to vanilla JS. But for now let's go with that. It's cached anyway probably, everyone uses jQuery, right?
@AngeloStavrow
Copy link
Owner

AngeloStavrow commented Nov 14, 2018

Thanks so much for submitting this PR! I've opened #40 for some additional tracking and will start reviewing your changes.

@AngeloStavrow AngeloStavrow changed the title Basic webmention support WIP - Basic webmention support Nov 14, 2018
@AngeloStavrow
Copy link
Owner

I've added WIP ("Work In Progress") to signal that this isn't yet ready to merge.

@AngeloStavrow AngeloStavrow added this to the v2.0 public release milestone Nov 14, 2018
@AngeloStavrow
Copy link
Owner

So this is taking a lot longer than I expected, as I learn about the intricacies of webmentions myself.

One thing that I'm wondering is if it's worth downloading the whole jQuery library if we're only really interested in $.getJson() — most modern browsers support ES6's fetch(), which might be a little more lightweight (IE doesn't support it, so we might need a polypill there).

@vikanezrimaya
Copy link
Author

vikanezrimaya commented Nov 19, 2018 via email

@ghost
Copy link

ghost commented Nov 23, 2018

About 88% of users can use fetch(). According to that, IE is still in use by ~2.5% of users.

@AngeloStavrow AngeloStavrow added wip Work in progress and removed wip labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wip Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants