ft-close-incident-reports: update incident report transitional state #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitau-kinuthia
force-pushed
the
ft-closed-incident-report-164101493
branch
3 times, most recently
from
efb7753 to
2df730e
Compare
kmazi
requested changes
Aug 21, 2019
| ).objects.get_or_create(asset_incident_report_id=self.incident_report.id) | ||
| self.transition_state = self.transition_state[0] | ||
|
|
||
| def test_update_asset_status_from_lost_to_available(self): |
There was a problem hiding this comment.
This is outside the context of the story. (fyi)
There was a problem hiding this comment.
Please elaborate on this
gitau-kinuthia
force-pushed
the
ft-closed-incident-report-164101493
branch
from
bdb4334 to
c1cb5d9
Compare
- Add model signals to listen for changes - Add unit tests for the signals [Delivers ##167427843]
- update model signals - Add unit tests for the updated signals [Delivers #164101493]
- Update model signals - Add unit tests for the updated signals - Fix failing linting checks - fix failing unit tests [Delivers #164101493]
gitau-kinuthia
force-pushed
the
ft-closed-incident-report-164101493
branch
from
c1cb5d9 to
978a7d2
Compare
gitau-kinuthia
force-pushed
the
ft-closed-incident-report-164101493
branch
from
978a7d2 to
50fc63d
Compare
- Add notifications model - add signals to create notifications - add unit tests - configure django_q and django_cache - resolve merge conflicts - update README.md - apply PR feedback - remove curly braces from notification body template - update functionality to close transition report on asset status change to `lost` or `damaged` [Delivers #161678177]
gitau-kinuthia
force-pushed
the
ft-closed-incident-report-164101493
branch
from
50fc63d to
e4fec7c
Compare
kmazi
reviewed
Aug 29, 2019
gitau-kinuthia
force-pushed
the
ft-closed-incident-report-164101493
branch
2 times, most recently
from
7ef99e7 to
0c2331b
Compare
- Add notifications model - add signals to create notifications - add model level unit tests - configure django_q and django_cache - resolve merge conflicts - update README.md - apply PR feedback - remove curly braces from notification body template - update functionality to close transition report on asset status change to `lost` or `damaged` - add api level api tests [Delivers #161678177]
gitau-kinuthia
force-pushed
the
ft-closed-incident-report-164101493
branch
from
0c2331b to
3c8b6f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add functionality for closing an incident report if an asset status moves from damaged/lost to
allocated/available
Description of Task to be completed?
Update an assets's
transition statetoCLOSEDwhen an Asset status is changed from(DAMAGED, LOST)to either(AVAILABLE, ALLOCATED)How should this be manually tested?
{base_url}/api/v1/incidence-reports/Any background context you want to provide?
What are the relevant pivotal tracker stories?
164101493
Postman Documentation
Screenshots (If applicable)