Add error handling when Amplify AppId is invalid and doesn't exist in the configured region #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
…p IDs Validates app IDs for branch deployments and provides clear error messaging when an invalid app ID is provided in the configured region.
|
Resolves #7 |
|
To provide feedback, navigate to the Files changed tab and leave comments on the proposed code changes. Choose Start review for each comment, and then choose Request changes, and I'll propose revised changes. |
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Amplifiyer
requested changes
May 16, 2025
Comment on lines
+26
to
+46
| resolveMainStackName = async (): Promise<string> => { | ||
| // If the backendId has a namespace (which is the appId for branch type), validate it exists | ||
| if (this.backendId.type === 'branch' && this.amplifyClient) { | ||
| try { | ||
| await this.amplifyClient.send( | ||
| new GetAppCommand({ appId: this.backendId.namespace }) | ||
| ); | ||
| } catch (error) { | ||
| if (error instanceof ResourceNotFoundException) { | ||
| const region = await this.amplifyClient.config.region(); | ||
| throw new BackendOutputClientError( | ||
| BackendOutputClientErrorType.INVALID_APP_ID, | ||
| `App with ID '${this.backendId.namespace}' does not exist in region ${region}. Please check the App ID and region configuration.` | ||
| ); | ||
| } | ||
| throw error; | ||
| } | ||
| } | ||
|
|
||
| return BackendIdentifierConversions.toStackName(this.backendId); | ||
| }; |
|
✅ I updated this pull request based on the feedback. To provide feedback, navigate to the Files changed tab and leave comments on the proposed code changes. Choose Start review for each comment, and then choose Request changes, and I'll propose revised changes. |
Implements validation for Amplify app IDs and adds comprehensive backend identifier resolution with test coverage. Includes support for sandbox fallback and proper error handling for invalid app IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the invalid app ID error handling in the deployment client. It adds validation to check if an Amplify app ID exists in the configured region when using branch-based deployments. If the app ID is not found, it throws a more user-friendly error message that includes both the invalid app ID and the region, helping developers quickly identify and fix app ID configuration issues. The changes primarily impact the backend identifier resolution and error handling components of the deployment system.