Fix KeyError in YouTube search by correcting JSON response parsing

[MukundSinghRajput]

Resolved a KeyError: 1 issue in the search_yt function that occurred when attempting to access page[1] in the JSON response from YouTube's search API. The original code assumed the response was a list or dict with a top-level key '1', but the actual structure starts directly with a 'response' key. Updated the code to remove the unnecessary [1] index and correctly navigate the nested structure starting from page["response"]["contents"]. This ensures the video list is parsed accurately from the API response. Tested with the query "Channa mere ya" and confirmed the fix works as expected.

Summary by Sourcery

Bug Fixes:

• Fix KeyError: 1 issue in the search_yt function.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a KeyError in the search_yt function by correcting the JSON response parsing logic. The code now correctly navigates the nested structure of the YouTube API response, starting from page["response"]["contents"], ensuring accurate video list parsing.

Sequence diagram for YouTube search API interaction

sequenceDiagram
  participant User
  participant Bot
  participant YouTube API

  User->>Bot: Sends a YouTube search query
  Bot->>YouTube API: Makes a request to the YouTube API
  activate YouTube API
  YouTube API-->>Bot: Returns JSON response
  deactivate YouTube API
  Bot->>Bot: Parses JSON response (corrected)
  Bot-->>User: Returns list of videos

Loading

Updated class diagram for YouTube API response parsing

classDiagram
  class YouTubeResponse {
    +response: Response
  }
  class Response {
    +contents: Contents
  }
  class Contents {
    +twoColumnSearchResultsRenderer: TwoColumnSearchResultsRenderer
  }
  class TwoColumnSearchResultsRenderer {
    +primaryContents: PrimaryContents
  }
  class PrimaryContents {
    +sectionListRenderer: SectionListRenderer
  }
  class SectionListRenderer {
    +contents: list[Content]
  }
  class Content {
    +itemSectionRenderer: ItemSectionRenderer
  }
  class ItemSectionRenderer {
    +contents: list[Video]
  }
  class Video {
    +videoRenderer: VideoRenderer
  }
  class VideoRenderer {
    +videoId: str
    +title: str
    +thumbnail: str
  }

  YouTubeResponse -- Response : contains
  Response -- Contents : contains
  Contents -- TwoColumnSearchResultsRenderer : contains
  TwoColumnSearchResultsRenderer -- PrimaryContents : contains
  PrimaryContents -- SectionListRenderer : contains
  SectionListRenderer -- Content : contains
  Content -- ItemSectionRenderer : contains
  ItemSectionRenderer -- Video : contains
  Video -- VideoRenderer : contains

Loading

File-Level Changes

Change	Details	Files
Corrected JSON parsing logic to handle the YouTube API response structure, resolving a KeyError.	Removed the unnecessary [1] index when accessing the JSON response. Updated the code to correctly navigate the nested structure starting from page["response"]["contents"].	eduu/plugins/youtube.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @MukundSinghRajput - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a more descriptive variable name than page to improve readability.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}