use google translator v2

[Sunda001]

Summary by Sourcery

Refactor the translation functionality to use a new Google Translate API (v2) via an external service. This change includes creating a Translator class to handle API requests and error handling, and updating the translate command and inline query to use the new API.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a Translator class to handle translation tasks using an external API. It refactors the translate command and tr_inline function to utilize this new class, improving code organization and error handling.

Sequence diagram for the translate command

sequenceDiagram
    participant User
    participant Client
    participant Translator
    User->>Client: /translate <target_lang> <text>
    Client->>Translator: translate(text, targetlang)
    alt Translation successful
        Translator-->>Client: Translation Result
        Client-->>User: Translated text
    else Translation error
        Translator-->>Client: Error message
        Client-->>User: Error message
    end

Loading

Sequence diagram for the tr_inline function

sequenceDiagram
    participant User
    participant Client
    participant Translator
    User->>Client: InlineQuery: <target_lang> <text>
    Client->>Translator: detect(text)
    Translator-->>Client: Source Language
    Client->>Translator: translate(text, sourcelang, targetlang)
    alt Translation successful
        Translator-->>Client: Translation Result
        Client-->>User: Translated text
    else Translation error
        Translator-->>Client: Error message
        Client-->>User: Error message
    end

Loading

Updated class diagram for Translator

classDiagram
    class Translator {
        - base_url: str
        - headers: dict
        + __init__(base_url: str)
        + detect(text: str) dict
        + translate(text: str, sourcelang: str, targetlang: str) dict
    }
    note for Translator "Handles translation tasks using an external API."

Loading

File-Level Changes

Change	Details	Files
Introduced a Translator class to encapsulate translation functionalities using an external API.	Added a constructor to set the base URL and headers for the translation API. Implemented detect method to detect the language of a given text. Implemented translate method to translate text from a source language to a target language. Implemented error handling for HTTP and other exceptions in both detect and translate methods.	eduu/plugins/translate.py
Refactored the translate command to use the new Translator class for text translation.	Initialized the Translator class. Replaced the previous translation logic with calls to the Translator class's translate method. Added error handling for translation failures. Updated the response to display the translated text from the new API.	eduu/plugins/translate.py
Refactored the tr_inline function to use the new Translator class for inline translations.	Utilized the Translator class to detect the source language of the text. Utilized the Translator class to translate the text to the target language. Handled potential errors during translation and displayed appropriate messages. Updated the inline query result to display the translated text from the new API.	eduu/plugins/translate.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Sunda001 - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• The password 'rahasia' is hardcoded in the headers. (link)

Overall Comments:

• Consider using environment variables or a configuration file to manage the base_url and headers in the Translator class.
• The inline query handler uses translation.text even when the translate function returns an error; it should use the text variable instead.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🔴 Security: 1 blocking issue
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}