Skip to content

(HD-2042) fix senseless retry in lease renewer on InvalidToken exception #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-2.7.4-alti
Choose a base branch
from
Open

(HD-2042) fix senseless retry in lease renewer on InvalidToken exception #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,17 @@ boolean renewLease() throws IOException {
+ (HdfsConstants.LEASE_HARDLIMIT_PERIOD/1000) + " seconds.) "
+ "Closing all files being written ...", e);
closeAllFilesBeingWritten(true);
} else if (e instanceof RemoteException) {
IOException ioe = ((RemoteException)e).unwrapRemoteException();
if (ioe instanceof InvalidToken) {
// no point in retrying this ever again, the token is not valid anymore
LOG.warn("Token invalid, unable to renew lease for client " + clientName + ". "
+ "Closing all files being written ...", e);
closeAllFilesBeingWritten(true);
} else {
// Let the lease renewer handle it and retry.
throw e;
}
} else {
// Let the lease renewer handle it and retry.
throw e;
Expand Down