Develop Anari #1539
Draft
Develop Anari #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depts->deps
…ine-DAV/ascent into task/2025_03_warpx_unit_test
…ine-DAV/ascent into task/2025_03_warpx_unit_test
…ine-DAV/ascent into task/2025_03_warpx_unit_test
Initial ANARI development via VTKm/Viskores
cyrush
reviewed
Jun 2, 2025
| fi | ||
|
|
||
| if ${build_anari}; then | ||
| echo 'set(ENABLE_ANARI ON CACHE BOOL "")' >> ${root_dir}/ascent-config.cmake |
Member
There was a problem hiding this comment.
We should only key off of ANARI_DIR, we don't need an extra switch to enable to disable anari.
cyrush
reviewed
Jun 2, 2025
| option(ENABLE_CUDA_DEBUG_CPU_ONLY "Enable CUDA CPU debugging" OFF) | ||
|
|
||
| # support ANARI rendering backend | ||
| option(ENABLE_ANARI "Build ANARI Support" OFF) |
Member
There was a problem hiding this comment.
we dont need addtional option, just key off ANARI_DIR
cyrush
reviewed
Jun 2, 2025
src/config/ascent_setup_deps.cmake
Outdated
| set(ANARI_DIR ${ASCENT_ANARI_DIR}) | ||
| endif() | ||
|
|
||
| if(EXISTS ${ANARI_DIR}/lib64/cmake/Kokkos/) |
Contributor
Author
There was a problem hiding this comment.
bingo! copy/paste typo
cyrush
reviewed
Jun 2, 2025
| else if(extract_type == "steering") | ||
| { | ||
| filter_name = "steering"; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Weird. I don't know. Probably messed up during a merge or something.
Thanks for catching
remove this check for now while we test and decide how to design things. anari vs. anari_vol & anari_pseudo & anari_points(?) idk all their renderers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.