Skip to content

Adds customization of cropper color and limit black overlay to image only #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

faltakam
Copy link

@faltakam faltakam commented Oct 6, 2015

  • Original color of cropper color boundaries is set as default value.
  • Black overlay stripes on sides, which appear when image aspect ration doesn't match canvas aspect ratio, can be confusing when image background color is the same as background color of canvas parent element. In that case image borders aren't visible and stripes that fill canvas appear to be part of the image. When resizing or moving crop you are restricted to image only but due to invisible image borders it appears that some part of image is inaccessible. Limiting overlay to image only fixes the issue.

@micros123
Copy link

Useful feature, code looking good, hope Allan can merge this soon?

@alinearielo
Copy link

+1 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants