買い物かごの取得にカタログから削除済みのアイテムのリストを含める #2756

fkoyama · 2025-05-22T07:49:38Z

この Pull request で実施したこと

買い物かごアイテム一覧取得APIのレスポンスに削除済みカタログアイテムのIDリストを追加しました。

{
    "buyerId": "",
    "account": {
    },
    "basketItems": [
        {
        }
    ],
    "deletedItemIds": [
        12,
        13
    ]
}

この Pull request では実施していないこと

削除済みカタログアイテムを買い物かごから削除する処理は別Issueにて対応予定です。

削除済みのアイテムを買い物かごから削除する機能を追加する #2613

Issues や Discussions 、関連する Web サイトなどへのリンク

なし

Copilot

Pull Request Overview

買い物かご取得APIのレスポンスに「削除済みカタログアイテムID」のリストを追加する変更です。

OpenAPIスキーマに deletedItemIds プロパティを追加
コントローラーとDTOに DeletedItemIds フィールドを追加
アプリケーションサービスで削除済みアイテムIDを抽出して戻り値に含めるロジックを実装

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/dressca-api.json	OpenAPIスキーマに `deletedItemIds` 配列を追加
samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/Controllers/BasketItemsController.cs	サービス呼び出しに `deletedCatalogItemIds` を追加し、レスポンスに設定
samples/Dressca/dressca-backend/src/Dressca.Web.Consumer.Dto/Baskets/BasketResponse.cs	DTOに `DeletedItemIds` プロパティを追加
samples/Dressca/dressca-backend/src/Dressca.ApplicationCore/ApplicationService/ShoppingApplicationService.cs	`GetBasketItemsAsync` の戻り値に削除済みアイテムIDを追加し、生成ロジックを実装

Comments suppressed due to low confidence (1)

samples/Dressca/dressca-backend/src/Dressca.ApplicationCore/ApplicationService/ShoppingApplicationService.cs:63

XMLドキュメントの <returns> セクションに新たに追加した DeletedItemIds の説明を追記してください。

/// </returns>

...dressca-backend/src/Dressca.ApplicationCore/ApplicationService/ShoppingApplicationService.cs

samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/dressca-api.json

samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/Controllers/BasketItemsController.cs

...tests/Dressca.UnitTests.ApplicationCore/ApplicationService/ShoppingApplicationServiceTest.cs

github-actions · 2025-05-26T06:42:24Z

Test Result 📝

Test was a success.
Completed in 6351ms with 247 passed, 0 failed and 0 skipped.

Coverage 📐

Summary


Generated on:	05/26/2025 - 06:42:22
Parser:	MultiReport (5x Cobertura)
Assemblies:	7
Classes:	126
Files:	119
Line coverage:	38% (1573 of 4131)
Covered lines:	1573
Uncovered lines:	2558
Coverable lines:	4131
Total lines:	8727
Branch coverage:	38.4% (254 of 660)
Covered branches:	254
Total branches:	660
Method coverage:	Feature is only available for sponsors
Tag:	217_15247987060

Dressca.ApplicationCore - 96%

Name	Line	Branch
Dressca.ApplicationCore	96%	81%
Dressca.ApplicationCore.Accounting.Account	92.8%	100%
Dressca.ApplicationCore.Accounting.AccountItem	88.8%
Dressca.ApplicationCore.ApplicationCoreServicesExtensions	100%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService	100%	70%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService.AssetStr eamInfo	100%
Dressca.ApplicationCore.ApplicationService.CatalogApplicationService	100%	75%
Dressca.ApplicationCore.ApplicationService.CatalogBrandNotExistingInReposit oryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogCategoryNotExistingInRepo sitoryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogItemNotExistingInReposito ryException	100%
Dressca.ApplicationCore.ApplicationService.OrderApplicationService	100%	75%
Dressca.ApplicationCore.ApplicationService.ShoppingApplicationService	99%	85%
Dressca.ApplicationCore.ApplicationService.TransactionScopeManager	100%	100%
Dressca.ApplicationCore.Assets.Asset	94.4%	100%
Dressca.ApplicationCore.Assets.AssetNotFoundException	100%
Dressca.ApplicationCore.Assets.AssetTypes	100%	100%
Dressca.ApplicationCore.Authorization.NotConnectedUserStore	0%
Dressca.ApplicationCore.Authorization.PermissionDeniedException	100%
Dressca.ApplicationCore.Authorization.Roles	100%
Dressca.ApplicationCore.Baskets.Basket	100%	100%
Dressca.ApplicationCore.Baskets.BasketItem	84.2%	75%
Dressca.ApplicationCore.Baskets.CatalogItemNotExistingInBasketException	100%
Dressca.ApplicationCore.Catalog.CatalogBrand	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogCategory	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogDomainService	100%	60%
Dressca.ApplicationCore.Catalog.CatalogItem	91%	66.6%
Dressca.ApplicationCore.Catalog.CatalogItemAsset	92.8%	75%
Dressca.ApplicationCore.Events	100%
Dressca.ApplicationCore.Ordering.Address	94.7%	100%
Dressca.ApplicationCore.Ordering.CatalogItemOrdered	96.7%	100%
Dressca.ApplicationCore.Ordering.EmptyBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.NullBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.Order	100%	90%
Dressca.ApplicationCore.Ordering.OrderFactory	100%
Dressca.ApplicationCore.Ordering.OrderItem	88.2%	25%
Dressca.ApplicationCore.Ordering.OrderItemAsset	85.7%	75%
Dressca.ApplicationCore.Ordering.OrderNotFoundException	100%
Dressca.ApplicationCore.Ordering.ShipTo	92.3%	75%

Dressca.EfInfrastructure - 16.5%

Name	Line	Branch
Dressca.EfInfrastructure	16.5%	10.2%
Dressca.EfInfrastructure.Configurations.Assets.AssetConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogBrandConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogCategoryConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemAssetConfigurati on	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderConfiguration	100%	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemAssetConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemConfiguration	100%	100%
Dressca.EfInfrastructure.DresscaDbContext	83.7%	50%
Dressca.EfInfrastructure.EfAssetRepository	0%	0%
Dressca.EfInfrastructure.EfBasketRepository	69.6%	50%
Dressca.EfInfrastructure.EfCatalogBrandRepository	20%	50%
Dressca.EfInfrastructure.EfCatalogCategoryRepository	20%	50%
Dressca.EfInfrastructure.EfCatalogRepository	28.5%	37.5%
Dressca.EfInfrastructure.EfInfrastructureServicesExtension	86.2%	75%
Dressca.EfInfrastructure.EfOrderRepository	100%	50%
Dressca.EfInfrastructure.Events	0%
Dressca.EfInfrastructure.HealthChecksBuilderExtensions	60%
Dressca.EfInfrastructure.Migrations.DresscaDbContextModelSnapshot	0%	0%
Dressca.EfInfrastructure.Migrations.InitialCreate	0%	0%

Dressca.Store.Assets.StaticFiles - 17.2%

Name	Line	Branch
Dressca.Store.Assets.StaticFiles	17.2%	0%
Dressca.Store.Assets.StaticFiles.Events	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStore	0%	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStoreServicesExtension	100%

Dressca.SystemCommon - 82%

Name	Line	Branch
Dressca.SystemCommon	82%	86.3%
Dressca.SystemCommon.BusinessError	100%	83.3%
Dressca.SystemCommon.BusinessErrorCollection	88.8%	100%
Dressca.SystemCommon.BusinessException	93.7%	100%
Dressca.SystemCommon.PagedList	0%	0%
Dressca.SystemCommon.Text.Json.DefaultJsonSerializerOptions	100%
System.ObjectExtensions	100%	100%
System.StringExtentions	100%	100%

Dressca.Web - 24%

Name	Line	Branch
Dressca.Web	24%	14%
__OptionValidationGeneratedAttributes	0%	0%
__OptionValidationStaticInstances	0%
Dressca.Web.Authorization.DummyAuthenticationHandler	0%
Dressca.Web.Authorization.StatusCodeMapAuthorizationMiddlewareResultHandler	0%	0%
Dressca.Web.Configuration.CookieSettingsValidator	0%	0%
Dressca.Web.Configuration.CookieSettings	0%	0%
Dressca.Web.Configuration.ValidateWebServerOptions	0%	0%
Dressca.Web.Configuration.WebServerOptions	0%
Dressca.Web.Controllers.ActionNameHelper	75%	50%
Dressca.Web.Controllers.ErrorController	8.3%	0%
Dressca.Web.Events	100%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider	7.8%	25%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider.HealthCheckControll erMetadata	0%	0%
Dressca.Web.Runtime.BusinessExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilterBase	100%	83.3%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilterBase	100%	75%

Dressca.Web.Consumer - 43.8%

Name	Line	Branch
Dressca.Web.Consumer	43.8%	28.7%
__OptionValidationGeneratedAttributes	0%	0%
__OptionValidationStaticInstances	0%
Dressca.Web.Consumer.Assets.AssetExtensions	87.5%	50%
Dressca.Web.Consumer.Baskets.BuyerIdFilterAttribute	96.5%	58.3%
Dressca.Web.Consumer.Baskets.HttpContextExtensions	100%	100%
Dressca.Web.Consumer.Configuration.CookieSettingsValidator	0%	0%
Dressca.Web.Consumer.Configuration.CookieSettings	100%	100%
Dressca.Web.Consumer.Configuration.ValidateWebServerOptions	0%	0%
Dressca.Web.Consumer.Configuration.WebServerOptions	100%
Dressca.Web.Consumer.Controllers.ApiModel.FindCatalogItemsQuery	0%
Dressca.Web.Consumer.Controllers.AssetsController	0%	0%
Dressca.Web.Consumer.Controllers.BasketItemsController	33.8%	30%
Dressca.Web.Consumer.Controllers.CatalogBrandsController	0%	0%
Dressca.Web.Consumer.Controllers.CatalogCategoriesController	0%	0%
Dressca.Web.Consumer.Controllers.CatalogItemsController	0%	0%
Dressca.Web.Consumer.Controllers.OrdersController	88.2%	50%
Dressca.Web.Consumer.Events	0%
Dressca.Web.Consumer.Mapper.BasketItemMapper	0%	0%
Dressca.Web.Consumer.Mapper.BasketMapper	9.5%	25%
Dressca.Web.Consumer.Mapper.CatalogBrandMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogCategoryMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogItemMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogItemSummaryResponseMapper	0%	0%
Dressca.Web.Consumer.Mapper.DtoMapperServicesExtension	100%
Dressca.Web.Consumer.Mapper.OrderMapper	95.1%	83.3%
Program	78.7%	87.5%

Dressca.Web.Consumer.Dto - 57.4%

Name	Line	Branch
Dressca.Web.Consumer.Dto	57.4%	****
Dressca.Web.Consumer.Dto.Accounting.AccountResponse	100%
Dressca.Web.Consumer.Dto.Baskets.BasketItemResponse	0%
Dressca.Web.Consumer.Dto.Baskets.BasketResponse	0%
Dressca.Web.Consumer.Dto.Baskets.PostBasketItemsRequest	100%
Dressca.Web.Consumer.Dto.Baskets.PutBasketItemsRequest	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogBrandResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogCategoryResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogItemResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogItemSummaryResponse	100%
Dressca.Web.Consumer.Dto.Ordering.OrderItemResponse	100%
Dressca.Web.Consumer.Dto.Ordering.OrderResponse	100%
Dressca.Web.Consumer.Dto.Ordering.PostOrderRequest	100%

github-actions · 2025-05-26T06:42:27Z

Test Result 📝

Test was a success.
Completed in 3818ms with 235 passed, 0 failed and 0 skipped.

Coverage 📐

Summary


Generated on:	05/26/2025 - 06:42:26
Parser:	MultiReport (5x Cobertura)
Assemblies:	7
Classes:	108
Files:	104
Line coverage:	34.2% (1318 of 3852)
Covered lines:	1318
Uncovered lines:	2534
Coverable lines:	3852
Total lines:	7977
Branch coverage:	37% (209 of 564)
Covered branches:	209
Total branches:	564
Method coverage:	Feature is only available for sponsors
Tag:	165_15247987058

Dressca.ApplicationCore - 93.5%

Name	Line	Branch
Dressca.ApplicationCore	93.5%	80%
Dressca.ApplicationCore.Accounting.Account	92.8%	100%
Dressca.ApplicationCore.Accounting.AccountItem	88.8%
Dressca.ApplicationCore.ApplicationCoreServicesExtensions	100%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService	100%	70%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService.AssetStr eamInfo	100%
Dressca.ApplicationCore.ApplicationService.CatalogApplicationService	100%	75%
Dressca.ApplicationCore.ApplicationService.CatalogBrandNotExistingInReposit oryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogCategoryNotExistingInRepo sitoryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogItemNotExistingInReposito ryException	100%
Dressca.ApplicationCore.ApplicationService.OrderApplicationService	100%	75%
Dressca.ApplicationCore.ApplicationService.ShoppingApplicationService	99%	85%
Dressca.ApplicationCore.ApplicationService.TransactionScopeManager	100%	100%
Dressca.ApplicationCore.Assets.Asset	88.8%	100%
Dressca.ApplicationCore.Assets.AssetNotFoundException	100%
Dressca.ApplicationCore.Assets.AssetTypes	100%	100%
Dressca.ApplicationCore.Authorization.NotConnectedUserStore	0%
Dressca.ApplicationCore.Authorization.PermissionDeniedException	100%
Dressca.ApplicationCore.Authorization.Roles	100%
Dressca.ApplicationCore.Baskets.Basket	100%	100%
Dressca.ApplicationCore.Baskets.BasketItem	84.2%	75%
Dressca.ApplicationCore.Baskets.CatalogItemNotExistingInBasketException	100%
Dressca.ApplicationCore.Catalog.CatalogBrand	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogCategory	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogDomainService	100%	60%
Dressca.ApplicationCore.Catalog.CatalogItem	91%	66.6%
Dressca.ApplicationCore.Catalog.CatalogItemAsset	85.7%	75%
Dressca.ApplicationCore.Events	100%
Dressca.ApplicationCore.Ordering.Address	57.8%	100%
Dressca.ApplicationCore.Ordering.CatalogItemOrdered	96.7%	100%
Dressca.ApplicationCore.Ordering.EmptyBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.NullBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.Order	90.4%	90%
Dressca.ApplicationCore.Ordering.OrderFactory	94.1%
Dressca.ApplicationCore.Ordering.OrderItem	88.2%	25%
Dressca.ApplicationCore.Ordering.OrderItemAsset	85.7%	75%
Dressca.ApplicationCore.Ordering.OrderNotFoundException	100%
Dressca.ApplicationCore.Ordering.ShipTo	53.8%	50%

Dressca.EfInfrastructure - 14.2%

Name	Line	Branch
Dressca.EfInfrastructure	14.2%	6%
Dressca.EfInfrastructure.Configurations.Assets.AssetConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogBrandConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogCategoryConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemAssetConfigurati on	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderConfiguration	100%	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemAssetConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemConfiguration	100%	100%
Dressca.EfInfrastructure.DresscaDbContext	83.7%	50%
Dressca.EfInfrastructure.EfAssetRepository	0%	0%
Dressca.EfInfrastructure.EfBasketRepository	0%	0%
Dressca.EfInfrastructure.EfCatalogBrandRepository	0%	0%
Dressca.EfInfrastructure.EfCatalogCategoryRepository	0%	0%
Dressca.EfInfrastructure.EfCatalogRepository	0%	0%
Dressca.EfInfrastructure.EfInfrastructureServicesExtension	86.2%	75%
Dressca.EfInfrastructure.EfOrderRepository	0%	0%
Dressca.EfInfrastructure.Events	0%
Dressca.EfInfrastructure.HealthChecksBuilderExtensions	60%
Dressca.EfInfrastructure.Migrations.DresscaDbContextModelSnapshot	0%	0%
Dressca.EfInfrastructure.Migrations.InitialCreate	0%	0%

Dressca.Store.Assets.StaticFiles - 17.2%

Name	Line	Branch
Dressca.Store.Assets.StaticFiles	17.2%	0%
Dressca.Store.Assets.StaticFiles.Events	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStore	0%	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStoreServicesExtension	100%

Dressca.SystemCommon - 82%

Name	Line	Branch
Dressca.SystemCommon	82%	86.3%
Dressca.SystemCommon.BusinessError	100%	83.3%
Dressca.SystemCommon.BusinessErrorCollection	88.8%	100%
Dressca.SystemCommon.BusinessException	93.7%	100%
Dressca.SystemCommon.PagedList	0%	0%
Dressca.SystemCommon.Text.Json.DefaultJsonSerializerOptions	100%
System.ObjectExtensions	100%	100%
System.StringExtentions	100%	100%

Dressca.Web - 29.7%

Name	Line	Branch
Dressca.Web	29.7%	13%
__OptionValidationGeneratedAttributes	0%	0%
__OptionValidationStaticInstances	0%
Dressca.Web.Authorization.DummyAuthenticationHandler	100%
Dressca.Web.Authorization.StatusCodeMapAuthorizationMiddlewareResultHandler	0%	0%
Dressca.Web.Configuration.CookieSettingsValidator	0%	0%
Dressca.Web.Configuration.CookieSettings	25%	0%
Dressca.Web.Configuration.ValidateWebServerOptions	0%	0%
Dressca.Web.Configuration.WebServerOptions	100%
Dressca.Web.Controllers.ActionNameHelper	0%	0%
Dressca.Web.Controllers.ErrorController	8.3%	0%
Dressca.Web.Events	100%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider	7.8%	25%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider.HealthCheckControll erMetadata	0%	0%
Dressca.Web.Runtime.BusinessExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilterBase	100%	83.3%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilterBase	100%	75%

Dressca.Web.Admin - 26.9%

Name	Line	Branch
Dressca.Web.Admin	26.9%	19.2%
Dressca.Web.Admin.Assets.AssetExtensions	0%	0%
Dressca.Web.Admin.Authorization.UserStore	0%	0%
Dressca.Web.Admin.Controllers.ApiModel.FindCatalogItemsQuery	0%
Dressca.Web.Admin.Controllers.AssetsController	0%	0%
Dressca.Web.Admin.Controllers.CatalogBrandsController	0%	0%
Dressca.Web.Admin.Controllers.CatalogCategoriesController	0%	0%
Dressca.Web.Admin.Controllers.CatalogItemsController	0%	0%
Dressca.Web.Admin.Controllers.UsersController	0%	0%
Dressca.Web.Admin.Events	0%
Dressca.Web.Admin.Mapper.CatalogBrandMapper	0%	0%
Dressca.Web.Admin.Mapper.CatalogCategoryMapper	0%	0%
Dressca.Web.Admin.Mapper.CatalogItemMapper	0%	0%
Dressca.Web.Admin.Mapper.DtoMapperServicesExtension	100%
Program	77.6%	75%

Dressca.Web.Admin.Dto - 0%

Name	Line	Branch
Dressca.Web.Admin.Dto	0%	****
Dressca.Web.Admin.Dto.CatalogBrands.GetCatalogBrandsResponse	0%
Dressca.Web.Admin.Dto.CatalogCategories.GetCatalogCategoriesResponse	0%
Dressca.Web.Admin.Dto.CatalogItems.GetCatalogItemResponse	0%
Dressca.Web.Admin.Dto.CatalogItems.PostCatalogItemRequest	0%
Dressca.Web.Admin.Dto.CatalogItems.PutCatalogItemRequest	0%
Dressca.Web.Admin.Dto.Users.GetLoginUserResponse	0%

削除済みカタログアイテムのIDリストを取得するよう買い物かごアイテム取得APIを修正。

002b3c4

fkoyama added this to the v1.2.0 milestone May 22, 2025

fkoyama self-assigned this May 22, 2025

fkoyama added the target: Dressca サンプルアプリケーションDresscaに関係がある label May 22, 2025

fkoyama linked an issue May 22, 2025 that may be closed by this pull request

買い物かごの取得にカタログから削除済みのアイテムのリストを含める #2612

Closed

1 task

tsuna-can-se requested review from tsuna-can-se and Copilot May 22, 2025 08:03

Copilot AI reviewed May 22, 2025

View reviewed changes

...dressca-backend/src/Dressca.ApplicationCore/ApplicationService/ShoppingApplicationService.cs Outdated Show resolved Hide resolved

samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/dressca-api.json Show resolved Hide resolved

fkoyama added 3 commits May 23, 2025 09:52

API仕様にdescriptionを反映。

cc2b33a

GetBasketItemsAsync()の戻り値のListをIReadOnlyListに統一。

cde8b05

削除済みアイテムのIDリストが返却されることを確認するテストを追加。

8a7a3e2

tsuna-can-se requested changes May 23, 2025

View reviewed changes

samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/Controllers/BasketItemsController.cs Outdated Show resolved Hide resolved

...tests/Dressca.UnitTests.ApplicationCore/ApplicationService/ShoppingApplicationServiceTest.cs Show resolved Hide resolved

fkoyama added 3 commits May 26, 2025 09:48

型安全キャストするよう変更。

2075bd8

戻り値についてのコメントを追加。

8176db1

GetBasketItesm()の戻り値を確認するテストを追加。

b06d66e

tsuna-can-se approved these changes May 26, 2025

View reviewed changes

tsuna-can-se merged commit 366e191 into main May 26, 2025
7 checks passed

tsuna-can-se deleted the feature/買い物かごの取得にカタログから削除済みのアイテムのリストを含める branch May 26, 2025 08:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

買い物かごの取得にカタログから削除済みのアイテムのリストを含める #2756

買い物かごの取得にカタログから削除済みのアイテムのリストを含める #2756

Uh oh!

fkoyama commented May 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

Uh oh!

Uh oh!

買い物かごの取得にカタログから削除済みのアイテムのリストを含める #2756

買い物かごの取得にカタログから削除済みのアイテムのリストを含める #2756

Uh oh!

Conversation

fkoyama commented May 22, 2025

この Pull request で実施したこと

この Pull request では実施していないこと

Issues や Discussions 、関連する Web サイトなどへのリンク

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 26, 2025

Test Result 📝

Coverage 📐

Uh oh!

github-actions bot commented May 26, 2025

Test Result 📝

Coverage 📐

Uh oh!

Uh oh!

Uh oh!