fix(incarnation-sapere): fix race condition in LsaNode causing ConcurrentModificationException in GraphQL subscriptions

[Copilot]

• Fix race condition in LsaNode causing ConcurrentModificationException
• Add comprehensive concurrency test for LsaNode
• Add GraphQL-specific test that reproduces original race condition
• Resolve Detekt lint issues by adding exception logging in test
• Fix Checkstyle violations in LsaNodeConcurrencyTest (star imports, trailing spaces, magic numbers, illegal catch, empty line separators)
• Move test constants to class-level static final fields
• Verify all tests pass and lint checks succeed

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[DanySK]

@copilot can you add a test in the graphql module that triggers the original problem, verify that it does indeed trigger the problem, and make sure that your patch solves?

Because I think the problem here could be more general: access to the environment should be performed using the simulation thread, or the risk of race conditions is always there.

[Copilot]

@copilot can you add a test in the graphql module that triggers the original problem, verify that it does indeed trigger the problem, and make sure that your patch solves?

Because I think the probl...

I've added a comprehensive test in the GraphQL module that reproduces the original race condition and verifies the fix works:

Test created: LsaNodeGraphQLConcurrencyTest in alchemist-graphql/src/jvmTest/kotlin

What the test does:

1. Loads a SAPERE simulation environment with LsaNodes
2. Creates 20 reader threads that simulate GraphQL subscription access via NodeSurrogate.contents()
3. Creates 20 writer threads that simulate simulation reactions modifying node state
4. Each thread performs 500 operations concurrently
5. Asserts that no ConcurrentModificationException occurs

Verification of fix:

• ✅ Test fails when run against the original (unfixed) LsaNode code
• ✅ Test passes when run against the synchronized LsaNode implementation

The test specifically targets the GraphQL access pattern that was causing the race condition: NodeSurrogate.contents() → LsaNode.getContents() → iteration over unsynchronized instances collection.

Commit: 793deb8

[DanySK]

@copilot build fails:

:alchemist-graphql:detektJvmTest FAILED	
/home/runner/work/Alchemist/Alchemist/alchemist-graphql/src/jvmTest/kotlin/it/unibo/alchemist/boundary/graphql/schema/model/LsaNodeGraphQLConcurrencyTest.kt:70:30: The caught exception is swallowed. The original exception could be lost. [SwallowedException]	
/home/runner/work/Alchemist/Alchemist/alchemist-graphql/src/jvmTest/kotlin/it/unibo/alchemist/boundary/graphql/schema/model/LsaNodeGraphQLConcurrencyTest.kt:92:38: The caught exception is swallowed. The original exception could be lost. [SwallowedException]	
/home/runner/work/Alchemist/Alchemist/alchemist-graphql/src/jvmTest/kotlin/it/unibo/alchemist/boundary/graphql/schema/model/LsaNodeGraphQLConcurrencyTest.kt:98:30: The caught exception is swallowed. The original exception could be lost. [SwallowedException]	

[Copilot]

@copilot build fails:

...

Fixed the Detekt SwallowedException lint issues by adding proper logging to the exception handlers in the GraphQL concurrency test. The test continues to work correctly, successfully completing 20,000 concurrent operations (10,000 reads + 10,000 writes) with 0 ConcurrentModificationExceptions, verifying that the race condition fix is working as expected.

Commit: 4bbab22

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[DanySK]

🎉 This PR is included in version 42.3.10 🎉

The release is available on:

• 42.3.10
• GitHub release

Your semantic-release bot 📦🚀