186 compile blocks using druid #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep
requested changes
May 19, 2025
| @@ -69,7 +69,6 @@ DRBlockClosure >> executeOn: interpreter [ | |||
| { #category : 'interpreting' } | |||
| DRBlockClosure >> generateCFG [ | |||
|
|
|||
| self error: #ToImplement. | |||
Comment on lines
2122
to
2130
| DruidTestInterpreter >> simpleMethodWithBlockReadingOuterVariable [ | ||
|
|
||
| | temp | | ||
| temp:=0. | ||
| self basicMethodWithBlock: [ |x|. | ||
| temp:=x. | ||
| x]. | ||
|
|
||
| ^ temp |
There was a problem hiding this comment.
This example is not reading the outer variable, its writing on it...
Comment on lines
+2109
to
+2115
| DruidTestInterpreter >> simpleMethodWithBlock [ | ||
|
|
||
| | temp | | ||
| temp:=0. | ||
| self basicMethodWithBlock: [ | x | | ||
| x:=5. | ||
| x]. |
Druid/DRBytecodeGenerator.class.st
Outdated
Comment on lines
371
to
373
| vectorTempName := aDRLoadTemporaryVariable isTempVectorTemp | ||
| ifTrue: [ self vectorTempName ] | ||
| ifFalse: [ 'vector1' ]. |
There was a problem hiding this comment.
This code is duplicated with the code in visitStoreTempVar:
Druid/DRControlFlowGraph.class.st
Outdated
|
|
||
| ^ self instructions select: [ :i | i isStoreTemporaryVariable ] | ||
| ^ self instructions select: [ :i | (i isStoreTemporaryVariable or: [i isLoadTemporaryVariable]) "and: [i isTempVectorTemp not]"]. |
Comment on lines
31
to
32
| "optimisations add: DRInline new. | ||
| optimisations add: DRInline new." |
Druid/DRMethodIRGenerator.class.st
Outdated
|
|
||
| aRBAssignmentNode variable binding originalVar isTempVectorTemp ifTrue: [ | ||
| | result | | ||
| "maybe should create DRStoreVectorTemporaryVariable ???" |
There was a problem hiding this comment.
Yes?
Otherwise, how do you differentiate normal stores?
Or for now all stores go to the temp vector?
Comment on lines
-188
to
+202
| withState: executionState. | ||
| aRBVariableNode variable isEscaping ifFalse: [ "should use isCopying" |
|
For now, all arguments and temporaries are all stored in temp Vector.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to compile block on DRUID:
To do:
Fix #186