Run bytecode meta-compilation tests fast #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Working with DRBytecodeScenarioCompilationTest
PalumboN
commented
May 13, 2025
Comment on lines
-1279
to
1013
| "Push temporary 0 -- aka first argument if there are arguments" | ||
| self doCompileBytecode: 64 selector: #pushTemporaryVariableBytecode. | ||
| cogit methodOrBlockNumArgs: 1. | ||
| cogit methodOrBlockNumTemps: 1. | ||
| cogit initSimStackForFramefulMethod: 2. | ||
|
|
||
| self compileBytecode: 76 selector: #pushReceiverBytecode thenDo: [ :generator | | ||
| cogit methodOrBlockNumArgs: 1. | ||
| cogit methodOrBlockNumTemps: 1. | ||
| cogit initSimStackForFramefulMethod: 2. | ||
|
|
||
| "Push argument 0" | ||
| cogit gen_pushTemporaryVariableBytecode. | ||
|
|
||
| "Push the temp, then pop it" | ||
| generator value. | ||
| cogit ssPopTopToReg: (cogit allocateRegNotConflictingWith: 0). | ||
|
|
||
| "Pop the value pushed by the first bytecode" | ||
| cogit ssPopTopToReg: ReceiverResultReg. | ||
| self compileBytecode: [ | ||
| "Push temporary 0 -- aka first argument if there are arguments" | ||
| self compileBytecodeSelector: #pushTemporaryVariableBytecode. | ||
|
|
||
| "Return the top of the stack which is the receiver" | ||
| cogit genUpArrowReturn ]. | ||
| "Push receiver, then pop it" | ||
| self compileBytecodeSelector: #pushReceiverBytecode. | ||
| cogit ssPopTopToReg: (cogit allocateRegNotConflictingWith: 0). | ||
|
|
||
| cogit genReturnTopFromMethod ]. | ||
|
|
||
| self | ||
| executeMethodWithReceiver: (memory integerObjectOf: 17) | ||
| executeMethodWithReceiver: memory nilObject | ||
| withArguments: #( 42 ). |
There was a problem hiding this comment.
This test is failing (just) on Ubuntu, now 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #169
This PR introduce the
DRBytecodeCompilationTestResourceresource for all the tests compiling bytecode handlers.The idea is:
I also removed all dependencies to PharoCodeGenerator (dead code)