This repository was archived by the owner on Sep 1, 2025. It is now read-only.
Removed the monkey patch of add_foreign_key #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe to the one in activerecord. Not clear that it is needed.
|
@jimgrimmett thanks for the PR, but as the repository readme says: https://github.com/AirHelp/partitioned#this-fork-is-no-longer-maintained We are no longer maintaining this fork. If you need some functionality feel free to create and maintain your own. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function prototype in the money patch is:
def add_foreign_key(referencing_table_name, referencing_field_name, referenced_table_name, referenced_field_name = :id)The function protoype in ActiveRecord is:
def add_foreign_key(to_table, options)This means that many of the documented ways to call add_foreign_key in a migration do not work.
Please feel free to tell what I am missing here and suggest a better solution, but with this change in place, everything is working again.