Block request if URL path contains path traversal patterns #599
+336
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
timokoessler
commented
May 12, 2025
| } | ||
|
|
||
| // Also check encoded paths | ||
| const decodedPath = decodeURIComponent(rawPath); |
There was a problem hiding this comment.
Does not cover double-encoding, should we?
There was a problem hiding this comment.
Question for @kapyteinaikido
Extracted from #595 Co-Authored-By: Hans Ott <[email protected]>
hansott
reviewed
May 12, 2025
library/vulnerabilities/path-traversal/checkUrlPathForPathTraversal.ts
Outdated
Show resolved
Hide resolved
hansott
reviewed
May 12, 2025
timokoessler
changed the title
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| return true; | ||
| } | ||
|
|
||
| // Only checks the url path for path traversal attacks, other inputs are checked using the sinks |
There was a problem hiding this comment.
Function handles multiple unrelated security concerns (IP blocking, user agent blocking, path traversal) in 185 lines.
Feedback
Post a comment with the following structure to provide feedback on this finding:
@AikidoSec feedback: [FEEDBACK]
Aikido will process this feedback into learnings to give better review comments in the future.
More info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.