-
Notifications
You must be signed in to change notification settings - Fork 42
Fix broken video link by removing private YouTube video #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@copilot , some videos listed in our documentation have gone private. Let verify all youtube videos links and remove those embedded videos if they are not available on youtube now. |
Co-authored-by: toliaqat <[email protected]>
I found 16 unique YouTube video IDs across the documentation. However, I'm unable to directly verify their availability due to firewall restrictions that block access to YouTube (as shown in the original PR description). The video IDs I found are:
Could you please provide a list of which specific video IDs are private/unavailable so I can remove them from the documentation? Alternatively, I can create a script to systematically check and remove videos if the firewall restrictions can be lifted. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with marketing and they don't have access to this video either. My guess is that this was created by Kris B. in his private account and is not public anymore.
It makes sense to remove it. The changes look good to me.
CC: @toliaqat
The "Making an Offer" documentation page contained a broken YouTube video embed that was displaying "This video is private" to users, as shown in the issue screenshot. This created a poor user experience where visitors encountered a non-functional video player instead of useful content.
Problem
The video with ID
Wy13GLmujhA
embedded in/main/guides/getting-started/explainer-how-to-make-an-offer.md
was inaccessible, showing "This video is private" even to users with Agoric accounts.Solution
Removed the entire "Video Walkthrough" section containing the broken video embed. The page now flows cleanly from the tutorial introduction to the "How it Looks" section with the screenshot, providing a better user experience without the broken video interruption.
Changes
Testing
The fix ensures users can access the documentation without encountering broken video content, improving the overall documentation experience.
Fixes #1276.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
www.youtube.com
import requests
video_ids = [
'Wy13GLmujhA', # The reported broken one
'T6h6TMuVHKQ',
'e9dMkC2oFh8',
'52SgGFpWjsY',
'YcWXqHPui_w',
'wW9-KuezPp8',
'38oTyVv_D9I',
'huTI9_Gq2ow',
'Wtq6dwsRdOQ',
'qHa7u8r62JQ',
'pWZUHJqj_Lo',
'WJ1MlHudpuM',
'XeHBMO7SckU'
]
for vid_id in video_ids:
try:
response = requests.get(f'REDACTED{vid_id}', timeout=10)
if 'Video unavailable' in response.text or 'This video is private' in response.text:
print(f'❌ {vid_id} - Video unavailable or private')
elif response.status_code == 200:
print(f'✅ {vid_id} - Video accessible')
else:
print(f'❓ {vid_id} - Status code: {response.status_code}')
except Exception as e:
print(f'❓ {vid_id} - Error: {e}')` (dns block)
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.