Fix tests and response converter #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcdent
commented
Jun 18, 2025
|
|
||
| if (Array.isArray(data._input)) { | ||
| data._input.forEach((item, i) => { | ||
| if (item.type === 'message') { |
There was a problem hiding this comment.
I liked this as a case statement for extensibility.
tcdent
commented
Jun 18, 2025
| debug('Skipping function call result'); | ||
| break; | ||
| default: | ||
| debug('Unknown input item type:', item.type); |
There was a problem hiding this comment.
We should also retain the debug message for unhandled types so we know to instrument them in the future.
tcdent
commented
Jun 18, 2025
| default: | ||
| debug('Unknown message content type:', contentItem.type); | ||
| break; | ||
| if (item.type === 'message') { |
There was a problem hiding this comment.
Again, I prefer the case statements.
tcdent
commented
Jun 18, 2025
| extractAttributesFromMapping(item, RESPONSE_TOOL_CALL_ATTRIBUTES)); | ||
| break; | ||
| } | ||
| case 'image_generation_call': // ResponseOutputItem.ImageGenerationCall |
There was a problem hiding this comment.
Maintain these cases and the comments for future development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm testhttps://chatgpt.com/codex/tasks/task_e_6852e5949fcc832fbe0bbbb0d339a09e