Improve error message semantics #61
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a minor patch to enhance error message semantics.
Not only is the above message misleading, but it's also logically incorrect.
"Invalid" infers some form of malformed input or failed validation, which requires existing data. Here, we only check if both
username
andapi_key
exist. This means we raise on the fact of non-existent data, but proceed to tell the user the data is invalid.Patches
RuntimeError
but update error message