-
Notifications
You must be signed in to change notification settings - Fork 161
Upgrade to yarn 4 #3546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade to yarn 4 #3546
Conversation
|
✅ Deploy Preview for adyen-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
size-limit report 📦
|
|
path: node_modules | ||
key: ${{ runner.os }}-cache-${{ env.cache-name }}-node-${{ matrix.node-version }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-cache-${{ env.cache-name }}-node-${{ matrix.node-version }}-yarn- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the restore-keys? If there's no match on the hash for yarn.lock
should we not just rebuild?
run: echo "PLAYWRIGHT_VERSION=$(jq -r '.devDependencies["@playwright/test"]' packages/e2e-playwright/package.json)" >> $GITHUB_ENV | ||
|
||
- name: Cache Playwright | ||
# Using a cache for the webkit binary files causes this error on subsequent runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also what is the difference in performance we get here, can you make the comparison?
@@ -0,0 +1 @@ | |||
nodeLinker: node-modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also would it be beneficial to change it to pnp or pnpm for example?
Summary
This PR upgrades the yarn package manager version we use for this project from version 1 to version 4. This provides a number of benefits especially when it comes to installs and our install time for packages seems to be reduced by an average of about 10 seconds.
As part of this upgrade we are now going to also be using corepack which can help us better manage package managers if we decide to switch to a different one.
Some other improvements have been included in this PR as well
CI perfomance benchmarking
Tested scenarios
Fixed issue: