-
Notifications
You must be signed in to change notification settings - Fork 36
[PlatformsAPIs] Code generation: update services and models #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
81b245a
to
280cf66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated code generation update for the Platforms APIs. The primary focus is on synchronizing the Go client library with the latest OpenAPI specification, introducing new functionalities for managing authorized card users, balance webhook settings, and network token provisioning. It also includes general code reformatting and minor functional enhancements to existing API methods and data models.
Highlights
- New API Services: Introduced AuthorizedCardUsersApi for managing card user authorizations and BalancesApi for configuring balance webhooks.
- Network Token Provisioning: Added new endpoints under PaymentInstrumentsApi to create and retrieve network token activation data, facilitating digital wallet integrations.
- API Client Code Refactoring: Standardized common.SendAPIRequest calls and error handling across numerous API service files, along with general import cleanup.
- Enhanced Tax Form Retrieval: The GetTaxForm method in AccountHoldersApi now supports an optional legalEntityId parameter for more specific tax form retrieval.
- Model Updates: Several data models were updated to reflect new fields, deprecated existing ones, or expanded enum values, such as adding Usage to Card and CardInfo models, and new bank identification types.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates services and models, likely from an auto-generated process. The changes introduce new APIs and update existing ones. However, there are some widespread issues that need to be addressed.
First, there are inconsistencies with Go imports across many of the modified API files. Some files remove necessary imports like encoding/json
and io/ioutil
while the code still uses them. New API files are also missing these imports, which will cause compilation errors.
Second, the error handling logic for API calls is duplicated across almost all API functions in this PR. This logic also ignores potential errors from ioutil.ReadAll
and has inconsistent indentation. I've added comments with suggestions to refactor this using a switch
statement for better readability, maintainability, and correctness. Addressing this pattern will significantly improve the codebase.
40ce5d6
to
d128849
Compare
f970374
to
77e3e3e
Compare
f9076cc
to
ad68ae0
Compare
6a8d490
to
d7844ae
Compare
83e0dec
to
ff2d11b
Compare
OpenAPI spec files or templates have been modified on 16-09-2025 by commit.