Fix CodeQL

[OscarSpruit]

Only set up signing on CI if env variables are available. This will make sure acceptance builds pass on places where we don't need signing.

[gemini-code-assist]

Summary of Changes

Hello @OscarSpruit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility and robustness of the CI build process by ensuring that application signing is only attempted when the necessary environment variables are present. This prevents build failures in environments, such as certain acceptance testing setups, where signing credentials might not be available or relevant, thereby streamlining the continuous integration pipeline.

Highlights

• Conditional Signing Configuration: The pull request introduces a conditional check for applying the signingConfigs.acceptance in the ci.local.gradle file. This configuration will now only be applied if the SIGNING_STORE_FILE environment variable is present.
• Improved CI Build Robustness: By making the signing configuration conditional, the change prevents build failures in CI environments where signing is not required or where the necessary signing environment variables are not available, ensuring acceptance builds pass more reliably.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Gradle configuration to conditionally apply the signing configuration based on the presence of environment variables. This is a good change to allow builds to pass in environments where signing is not required, like on CodeQL. I've added one suggestion to make the check more robust by verifying all required signing variables, not just one.

[github-actions]

✅ No public API changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud