Created Pull Request Template #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kariabancroft
suggested changes
Jan 23, 2017
| # Mood Analysis | ||
| Congratulations! You're submitting your assignment. | ||
|
|
||
| ## Comprehension Questions |
Contributor
There was a problem hiding this comment.
One question that I have on this assignment is that is also comes along with those comprehension questions in the original assignment. Should we move them into here to consolidate the comprehension?
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| | Why does 03/13 come out as neutral when it should be happy? How could we fix this? | | | ||
| | Where should we call strip_punctuation? Does it matter? Why? | | | ||
| | What are you going to do if there aren't at least 3 happy days? Where do you need to handle that case? | | | ||
| | Should you use an array or a hash to solve this problem? Why? | | |
Contributor
There was a problem hiding this comment.
This needs to be more specific
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| | Where should we call strip_punctuation? Does it matter? Why? | | | ||
| | What are you going to do if there aren't at least 3 happy days? Where do you need to handle that case? | | | ||
| | Should you use an array or a hash to solve this problem? Why? | | | ||
| | What if we eventually want to add feelings to our analysis? Can we write this code in a way that will prevent us from having to re-write it later? | | |
Contributor
There was a problem hiding this comment.
I'm not sure what this question is asking - is it possible to make it more specific?
Contributor
Author
|
Changes made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.