Shari Meggs - FarMar #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er. Helper has FARMAR
… structure for the initialize method
…wo tests built in spec
… to also make sure in the all method that values were converted into fixnums
…d depend on the vend ID
…lly put in the id instead of the amount of times that Id appears
…y and the other checked that the method would not include dates outside the range
… a bit in the all method but decided to only change the date in the string
…re not in the correct order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be reviewed on my tests as I was not sure what was too specific or too broad. The best diversity of tests can be found in market and vendor specs. If there is anything else scary that stands out, I would be happy to work on it. I did go through and tried to format the indentation.