Sphinx - Sarah Koch and Salma Anany #22

SalmaAnany · 2024-09-27T16:17:08Z

No description provided.

…dditional assertion statements are still skipped.

…m_watchlist_to_empty_watched() in test_wave_01.py, adds assert statements to test that the correct movie was added to "watched"

…atched(). Adds assertions to test that the correct movie was added to "watched". Removes raised exception and comments out skip decorator.

…_movie_from_watchlist_to_watched(), which checked against GENRE_1 and RATING_1 instead of movie_to_watch["genre"] and movie_to_watch["rating"], which could cause tests to falsely report as failed.

…mented out in test_wave_02.py. Wave 2 user data uncommented out in play_tester.py.

…r waves. Comments out all skip decorators in test_wave_05.py, completes test code for test_new_genre_rec_from_empty_friends(). Adds new function get_new_rec_by_genre() to Wave 5 in party.py, passing first 3 wave 5 tests. Cleans up inconsistent whitespace between functions in party.py.

… 5 tests (returns empty list if user has no favorites, returns user favorites if friends have watched no movies).

…s. Refactoring, playtesting not yet complete.

Co-authored-by: SalmaAnany <[email protected]>

…n to bottom of wave for readability.

…s all existing docstrings use identical display formatting.

…hitespace in Wave 4.

…tes(). Changes some variable names for clarity.

…mented out.

… Wave 3. Makes docstrings more concise and to the point. Makes additional changes for clarity and standardization, including using comprehensions where appropriate, formatted for readability.

yangashley

Nice work on viewing-party, Sarah and Salma!

I also see that you two made frequent commits, nice job!

Let me know if you have any questions about my review comments.

yangashley · 2024-10-01T21:51:16Z

.idea/.gitignore

Did you mean to add and commit these files in the .idea directory? I don't think these changes are needed for the project and should be removed from the tracked changes before opening a PR.

While adding these changes as a PR, doesn't affect this project right now, when you're in industry it's best practice to only commit changes relevant to your work so that the codebase doesn't become cluttered. Be sure to review what files you have staged for commit before you add them so that you don't add files that shouldn't be tracked to the commit history.

yangashley · 2024-10-01T22:01:57Z

tests/test_wave_01.py

+    assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1
+    assert updated_data["watched"][0]["genre"] == GENRE_1
+    assert updated_data["watched"][0]["rating"] == RATING_1


Nice job adding assertions to this test 👍

yangashley · 2024-10-01T22:05:08Z

tests/test_wave_01.py

+    assert updated_data["watched"][1]["title"] == movie_to_watch["title"]
+    assert updated_data["watched"][1]["genre"] == movie_to_watch["genre"]
+    assert updated_data["watched"][1]["rating"] == movie_to_watch["rating"]


You could capture the logic written in lines 173-175 as:

assert HORROR_1 in updated_data["watched"]

Also since you're testing that HORROR_1 is in the watched list, you might also to test that HORROR_1 is not in the watchlist.

yangashley · 2024-10-01T22:06:43Z

tests/test_wave_03.py

+    assert INTRIGUE_3 in friends_unique_movies
+    assert FANTASY_4 in friends_unique_movies
+    assert HORROR_1 in friends_unique_movies


👍 Nice job checking that the correct movies are in friends_unique_watched. Consider adding an assertion to check that the movie that was added to the first friend's watched list on line 50 was not added to Amanda's watched list:

assert INTRIGUE_3 not in amandas_data["watched"]

yangashley · 2024-10-01T22:07:10Z

tests/test_wave_05.py


-@pytest.mark.skip()
+    # Assert
+    assert len(recommendations) == 0


Writing the assertion len(recommendations) == 0 only enforces that recommendations is something we can get the length of (and it's empty). If we write the assertion like assert recommendations == [] it guarantees the thing in recommendations is actually a list (and it's empty).

yangashley · 2024-10-01T23:52:33Z

viewing_party/party.py

+    return ([rec for rec in available_recs
+                if rec['genre'] == most_watched_genre
+                and not any(movie['title'] == rec['title']
+                for movie in user_data['watched'])])


This is also pretty dense and a little difficult to read. With a list comprehension like this, I might suggest writing it out in for-loops so you don't compromise readability.

yangashley · 2024-10-01T23:57:45Z

viewing_party/party.py

+            for friend in user_data['friends'])):
+        return []
+
+    available_recs = get_available_recs(user_data)


Why do we call get_available_recs? This function returns a list of movies where a user hasn't watched, but a friend has, and the "host" of the movie is a service that is in the user's "subscriptions"

For this function, we want to recommend movies that a user hasn't watched, but friends have watched, and the movie's genre is the same as the most_watched_genre. So we don't need to consider a movie's host when adding a movie to the list of recommended movies here.

We could use get_friends_unique_watched(user_data) though to get all the movies only watched by friends and then compare the genres of those movies to most_watched_genre

yangashley · 2024-10-02T00:05:01Z

viewing_party/party.py

+    friends_watched_titles = ({
+        movie['title'] for friend in user_data['friends']
+        for movie in friend['watched']
+    })


Could we use get_friends_watched_list() here instead?

yangashley · 2024-10-02T00:18:47Z

viewing_party/party.py

+    rec_from_favorites = ([
+        favorite for favorite in user_data['favorites']
+        if favorite['title'] not in friends_watched_titles
+    ])


This is starting to stretch how much we should put into comprehension. For me, this isn't as readable as it could be if we used a for loop.

What about something like

def get_rec_from_favorites(user_data): friends_movies = get_friends_watched_list(user_data) fav_movie_rec_list = [] for movie in user_data["favorites"]: if movie not in friends_movies: fav_movie_rec_list.append(movie) return fav_movie_rec_list

yangashley · 2024-10-02T00:22:16Z

viewing_party/party.py

+    genre_count = {}
+    for movie in user_data['watched']:
+        genre = movie['genre']
+        genre_count[genre] = genre_count.get(genre, 0) + 1
+
+    most_watched_genre = None
+    max_count = 0
+    for genre, count in genre_count.items():
+        if count > max_count:
+            max_count = count
+            most_watched_genre = genre
+
+    return most_watched_genre


svankoch and others added 30 commits September 23, 2024 11:23

Adds comment to README.md Viewing Party section

c1a004c

make change to README skills

afbb378

Hello Hello

3a402b6

Removes skip decorators for completed Wave 1 tests. Those requiring a…

fcece58

…dditional assertion statements are still skipped.

Removes raised exception and skip decorator from test_moves_movie_fro…

eba0c6f

…m_watchlist_to_empty_watched() in test_wave_01.py, adds assert statements to test that the correct movie was added to "watched"

Modifies test_wave_01.py function test_move_movie_from_watchlist_to_w…

c9d710d

…atched(). Adds assertions to test that the correct movie was added to "watched". Removes raised exception and comments out skip decorator.

Modifies test_wave_01.py. Corrects assertion statements in test_moves…

ba1c3b9

…_movie_from_watchlist_to_watched(), which checked against GENRE_1 and RATING_1 instead of movie_to_watch["genre"] and movie_to_watch["rating"], which could cause tests to falsely report as failed.

step1 in wave 1

8388381

Merge branch 'main' of https://github.com/SalmaAnany/viewing-party

32d9de6

funcation 3 in wave 1

5b35a23

complete everything in wave one except tests

721c540

complete everything in wave one except tests

fb72097

Merge branch 'main' of https://github.com/SalmaAnany/viewing-party

a3f6d60

complete funcation one in wave Three

5fbb015

Adds get_watched_avg_rating() to party.py. Wave 2 skip decorators com…

975c107

…mented out in test_wave_02.py. Wave 2 user data uncommented out in play_tester.py.

Adds get_most_watched_genre() to party.py. All Wave 2 tests now pass.

ae7c208

complete funcation one in wave Three

2a277cb

Merge remote-tracking branch 'origin/main'

aa28e59

complete wave Four

ee3431f

Adds get_new_rec_by_genre() to Wave 5 in party.py. Passes 2 of 3 Wave…

9861387

… 5 tests (returns empty list if user has no favorites, returns user favorites if friends have watched no movies).

Updates get_rec_from_favorites() in Wave 5, which now passes all test…

ae66c23

…s. Refactoring, playtesting not yet complete.

Refactors Wave 3 in party.py.

40f9535

Co-authored-by: SalmaAnany <[email protected]>

Refactors Wave 3 in party.py.

b2fe61b

Co-authored-by: SalmaAnany <[email protected]>

Merge branch 'main' of https://github.com/SalmaAnany/viewing-party

9de130c

Refactors create_movie() in Wave 1 of party.py

5d2c539

Refactors add_to_watched() in party.py Wave 1

3380b80

Refactors add_to_watchlist() in party.py Wave 1

0e2390f

Refactors watch_movie() in party.py Wave 1

3e3603f

Adds docstrings to the Wave 1 functions in party.py.

f18e10f

svankoch added 9 commits September 26, 2024 18:58

Refactors get_watched_avg_rating() in Wave 2 of party.py

1ac0638

Refactors get_most_watched_genre() in party.py Wave 2

404c24b

Adds docstrings to Wave 3 functions in party.py. Moves helper functio…

7afc59d

…n to bottom of wave for readability.

Adds docstrings to get_available_recs() in Wave 4 of party.py. Ensure…

abc8360

…s all existing docstrings use identical display formatting.

Renames variable in get_available_recs() for clarity. Removes extra w…

c871272

…hitespace in Wave 4.

Renames additional variable in Wave 4 for clarity.

ceaf7ce

Refactors Wave 5 functions. Creates docstring for get_rec_from_favori…

b952f0e

…tes(). Changes some variable names for clarity.

Deletes skip decorators and raised exceptions which were previous com…

12a43db

…mented out.

Refactors waves further, creating and refactoring helper functions in…

b9ff167

… Wave 3. Makes docstrings more concise and to the point. Makes additional changes for clarity and standardization, including using comprehensions where appropriate, formatted for readability.

SalmaAnany changed the title ~~Salma Anany- Ada C22 Sphinx Class~~ Sphinx - Salma Anany and Sarah Koch Sep 27, 2024

SalmaAnany changed the title ~~Sphinx - Salma Anany and Sarah Koch~~ Sphinx - Sarah Koch and Salma Anany Sep 27, 2024

yangashley reviewed Oct 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sphinx - Sarah Koch and Salma Anany #22

Sphinx - Sarah Koch and Salma Anany #22

Uh oh!

SalmaAnany commented Sep 27, 2024

Uh oh!

yangashley left a comment

Uh oh!

yangashley Oct 1, 2024

Uh oh!

yangashley Oct 1, 2024

Uh oh!

yangashley Oct 1, 2024

Uh oh!

yangashley Oct 1, 2024

Uh oh!

yangashley Oct 1, 2024

Uh oh!

yangashley Oct 1, 2024

Uh oh!

yangashley Oct 1, 2024

Uh oh!

yangashley Oct 2, 2024

Uh oh!

yangashley Oct 2, 2024

Uh oh!

yangashley Oct 2, 2024

Uh oh!

Uh oh!

Sphinx - Sarah Koch and Salma Anany #22

Are you sure you want to change the base?

Sphinx - Sarah Koch and Salma Anany #22

Uh oh!

Conversation

SalmaAnany commented Sep 27, 2024

Uh oh!

yangashley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!