Phoenix C22- Tatyana Venanzi #12

taty1202 · 2024-09-26T23:45:35Z

Co-worked with Kristina Nguyen

…st_wave_01.py

… time

kelsey-steven-ada

Nice work on your first pair project Kristina & Tatyana!

kelsey-steven-ada · 2024-09-30T17:54:16Z

.gitignore

@@ -143,3 +143,4 @@ dmypy.json

 # Cython debug symbols
 cython_debug/
+tests/test_wave_01.py


Was this an intentional change to the .gitignore?

not intentional at all, is that something we would need to fix?

You can go back and fix it if you'd like the practice, but it's mostly something to really keep an eye out for in the future. .gitignore should only contain files that we want to keep out of version control (out of the git repo).

kelsey-steven-ada · 2024-09-30T18:15:53Z

tests/test_wave_01.py

    # *******************************************************************************************
    # ****** Add assertions here to test that the correct movie was added to "watched" **********
    # *******************************************************************************************
+    # assert MOVIE_TITLE_1 not in updated_data["watchlist"]
+    # assert MOVIE_TITLE_1 in updated_data["watched"]
+    assert janes_data not in updated_data["watchlist"]


I would like y'all to revisit this test if you have time. I don't believe this assert is doing what you intend. janes_data is the full structure:

janes_data = { "watchlist": [{ "title": MOVIE_TITLE_1, "genre": GENRE_1, "rating": RATING_1 }], "watched": [] }

watched is a part of this data structure, so we likely would not want to try referencing the structure holding it inside of watched. We also cannot add mutable data structures like janes_data as keys to a dictionary, so janes_data not in updated_data["watchlist"] is always going to evaluate to True.

We want to confirm that the items in the watched and watchlist changed how we expected.

What syntax do we need to access the data inside of the watched list?

What values inside of that list do we want to confirm to ensure that the movie keys are each what we expect?

kelsey-steven-ada · 2024-09-30T18:18:56Z

tests/test_wave_01.py

    # *******************************************************************************************
    # ****** Add assertions here to test that the correct movie was added to "watched" **********
    # *******************************************************************************************
+    assert movie_to_watch not in updated_data["watchlist"]


Nice use of in to check all the dictionary values at once!

We assert that movie_to_watch is not in updated_data["watchlist"], but does that alone confirm that is has been moved to watched?

What other asserts to we need to add to be certain that each of the movies with the correct data in the lists where they belong, and no data was altered when moving them from list to list?

kelsey-steven-ada · 2024-09-30T18:37:36Z

tests/test_wave_03.py

    # *************************************************************************************************
    # ****** Add assertions here to test that the correct movies are in friends_unique_movies **********
    # **************************************************************************************************
+    assert INTRIGUE_3 in friends_unique_movies


friends_unique_movies contains 3 values, so we should write assert statements to confirm ALL of the contents are what we expect. What other movies should be in the list, and how can we test for them??

kelsey-steven-ada · 2024-09-30T19:36:42Z

tests/test_wave_05.py

+    # raise Exception("Test needs to be completed.")
+    # Act
+    recommendations = get_new_rec_by_genre(sonyas_data)
    # *********************************************************************
    # ****** Complete the Act and Assert Portions of these tests **********
    # *********************************************************************
+    #Assert
+    assert len(recommendations) == 0


Nice Act & Assert!

To make it easier to understand what's happening at a glance, I recommend removing the pre-existing exception and comment, since they aren't necessary once the test is completed. Right now the act and assert sections of the test blend into one code chunk. With the comments removed, we should use new lines to create visual space and separate the steps.

kelsey-steven-ada · 2024-10-01T22:27:48Z

viewing_party/party.py

+
+    #loops through movies in the total_friends_watched list to compare (in the if statement) if the movie is not in the user's watched list and hasn't appeared in the unique_movies_list (checks for duplicates) to then append the unique movie
+    for unique_movies in total_friends_watched:
+        if (unique_movies not in user_data["watched"]) and (not unique_movies in unique_movies_list):


This line is a bit long, I’d suggest breaking this statement apart. The PEP 8 style guide recommends limiting lines to a max of 79 characters to make code easier to read, especially with multiple editor windows open: https://peps.python.org/pep-0008/#maximum-line-length.

kelsey-steven-ada · 2024-10-01T23:04:11Z

viewing_party/party.py

 # -----------------------------------------
 # ------------- WAVE 4 --------------------
 # -----------------------------------------

+def get_available_recs(user_data):


Solid approach! Since we need to consider only movies that one of our friends have watched but we have not, how could we reuse our previous functions get_friends_unique_watched to simplify the code?

kelsey-steven-ada · 2024-10-01T23:04:59Z

viewing_party/party.py

+        # loop through their moviees
+        for friend_movie in friend["watched"]:
+            # check if user hasn't watched the movie and if host (streaming services) is also under user
+            if (friend_movie["title"] not in user_watched_list and friend_movie["host"] in user_data["subscriptions"] and friend_movie not in recommendations):


This line should be split up for length & readability

kelsey-steven-ada · 2024-10-01T23:12:19Z

viewing_party/party.py

 # -----------------------------------------
 # ------------- WAVE 5 --------------------
 # -----------------------------------------

+def get_new_rec_by_genre(user_data):


get_new_rec_by_genre is duplicating work that we've already done to find the most common genre for a user and only look at movies that at least one friend has seen, but we have not. How can we reuse our previous functions get_most_watched_genre and get_friends_unique_watched to simplify our approach here?

kelsey-steven-ada · 2024-10-01T23:14:00Z

viewing_party/party.py

+    #returns list of recommended movies
+    return recommended_list
+
+def get_rec_from_favorites(user_data):


How could we reuse our prior function get_unique_watched to simplify the code here?

taty1202 and others added 19 commits September 23, 2024 16:01

Completed remaining functions under wave 1 and passed all tests in te…

c019a01

…st_wave_01.py

kristina commit

085a677

Merge branch 'main' of https://github.com/taty1202/viewing-party

506420e

test wave 1 passed

383de95

tatyana commit to do git pull request

f9e601b

commit to resolve conflict

7b31601

updated code for wave two

fc85e5f

wave 3 function 1 finished

726bde6

Merge branch 'main' of https://github.com/taty1202/viewing-party

f6067ee

made first function of wave 3

173cc44

kristina commit to push wave 3 functions

f8b09ce

merge conflict commit

e30d8b5

made wave 4 and passed all tests during co-working time with Kristina

3ba858a

cleaned function 3 to commit

7b6eb61

kristina commit for merge conflicts

718a932

cleaned up sample data for wave 3

adb79a0

added comments to wave 3 functions

eb7de8b

fixed assertion in wave 3 tests

47d7a95

completed wave 5 and passed tests 1- 5 with Kristina during coworking…

4dc4342

… time

kelsey-steven-ada reviewed Oct 1, 2024

View reviewed changes

Kristina added 2 commits October 8, 2024 14:55

Co-authored-by: Tatyana Venanzi <[email protected]>

9541cce

fully refactored with Taty

d3f14d2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Phoenix C22- Tatyana Venanzi #12

Phoenix C22- Tatyana Venanzi #12

Uh oh!

taty1202 commented Sep 26, 2024

Uh oh!

kelsey-steven-ada left a comment

Uh oh!

kelsey-steven-ada Sep 30, 2024

Uh oh!

kstinanguyen Oct 8, 2024

Uh oh!

kelsey-steven-ada Oct 8, 2024

Uh oh!

kelsey-steven-ada Sep 30, 2024 •

edited

Loading

Uh oh!

kelsey-steven-ada Sep 30, 2024

Uh oh!

kelsey-steven-ada Sep 30, 2024

Uh oh!

kelsey-steven-ada Sep 30, 2024

Uh oh!

kelsey-steven-ada Oct 1, 2024

Uh oh!

kelsey-steven-ada Oct 1, 2024

Uh oh!

kelsey-steven-ada Oct 1, 2024

Uh oh!

kelsey-steven-ada Oct 1, 2024

Uh oh!

kelsey-steven-ada Oct 1, 2024

Uh oh!

Uh oh!

Phoenix C22- Tatyana Venanzi #12

Are you sure you want to change the base?

Phoenix C22- Tatyana Venanzi #12

Uh oh!

Conversation

taty1202 commented Sep 26, 2024

Uh oh!

kelsey-steven-ada left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kelsey-steven-ada Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kelsey-steven-ada Sep 30, 2024 •

edited

Loading