Sphinx-Denise-Ajar-Lorraine #1

shiyinxi · 2024-09-25T06:08:10Z

No description provided.

…ptions)

mikellewade · 2024-10-03T17:29:01Z

viewing_party/party.py

+    new_movie_info = {"title": title, "genre": genre, "rating": rating}
+    return new_movie_info


since we aren't really doing anything with new_movie_info besides returning it, I would be okay with just returning the dictionary directly like so:

return {"title": title, "genre": genre, "rating": rating}

fixed and pushed!

mikellewade · 2024-10-03T17:33:57Z

viewing_party/party.py

+    for movie in user_data["watchlist"]:
+        if movie["title"] == title:
+            user_data["watchlist"].remove(movie)
+            user_data["watched"].append(movie)


For this line, did we write a function that could do this for us? I know it's trivial here, but it helps to get in the habit so we can keep our code DRY. Also, why write a function if we won't use it? ✨ Great work on this function overall!

fixed and pushed!

mikellewade · 2024-10-03T17:45:29Z

viewing_party/party.py

+    for movie in user_data["watchlist"]:
+        if movie["title"] == title:
+            user_data["watchlist"].remove(movie)


So now that we have talked about Big O analysis, we know that .remove has a time complexity of O(n) since it needs to look through every element in a list to find the sought after value. Right now, this loop has an outer loop of O(n) and you when you find the movie to remove you have another O(n) operation. How could we circumvent using remove? (Hint: Think about list comprehension)

Also in this implementation, we will only use remove once, but in other filtering problems we might have to do this for multiple elements so it doesn't hurt to get in the habit now.

question: will ask about it in office hours

fixed this thanks for explaining!

mikellewade · 2024-10-03T17:52:02Z

viewing_party/party.py

+def get_watched_avg_rating(user_data):
+    if not user_data["watched"]:
+        return 0
+
+    total_movie_ratings = 0

+    for movie_rating in user_data["watched"]:
+        total_movie_ratings += movie_rating["rating"]
+
+    average_movie_rating = total_movie_ratings / len(user_data["watched"])
+
+    return average_movie_rating


mikellewade · 2024-10-03T17:55:15Z

viewing_party/party.py

+    for single_movie in user_data["watched"]:
+        genre_type = single_movie.get("genre")
+        if genre_type:
+            frequency_of_genre_index[genre_type] = frequency_of_genre_index.get(genre_type,0) + 1


Love this line right here! A great example of using the .get method that dictionaries supply us with!

mikellewade · 2024-10-03T19:23:55Z

viewing_party/party.py

+            if frequency_of_genre_index[genre_type] > max_frequency:
+              max_frequency = frequency_of_genre_index[genre_type]
+              most_watched_genre = genre_type


Great work on this logic, ~~I now that you've done it a few times (adagrams and PSE 1) I think it would be okay to use the max function that python provides us.~~

EDIT: Discussing with other instructors we came to the conclusion that we think that it's best to not use max until Unit 2 or to use it and have the logic written out and commented out so we know that you understand the logic behind it.

mikellewade · 2024-10-03T19:31:00Z

viewing_party/party.py

+    my_friends_unique = [movie["title"] for my_friends in user_data["friends"] 
+                         for movie in my_friends["watched"]]


Great job with the list comprehension here, I would say this is the most I would try to fit in a comprehension. I think that anything pass this would lower the readability of your code.

mikellewade · 2024-10-03T19:33:53Z

viewing_party/party.py

+    my_unique_movies = [movie for movie in user_data["watched"] 
+                        if movie["title"] not in my_friends_unique]   


Since my_friends_unique is a list, the in operator has an O(n) time complexity here. Is there another data structure that we can use to circumvent the complexity here? How would that change our code?

question: will ask about it in office hours

A set can take a constant amount of time to find the elements. A list would have to look at n-1.

in my_unique_movies....

if movie["title"] not in my_friends_unique]

searching through the my_friends_unique variable would take a constant if it was a set rather than if it was a list.

mikellewade · 2024-10-03T19:35:57Z

viewing_party/party.py

+            if movie["title"] not in my_movie_titles and movie not in friends_unique_movies:
+                friends_unique_movies.append(movie) 
+
+    return list(friends_unique_movies)


Being that friends_unique_movies is a list already, is there a reason that we wrap it in list()?

fixed and pushed!

mikellewade · 2024-10-03T19:37:53Z

viewing_party/party.py

+
+def get_available_recs(user_data):
+    recommended_movies = []
+    friends_unique_movies = get_friends_unique_watched(user_data)


Using functions that you've already written! Keeping your code DRY! 🎉

mikellewade · 2024-10-03T19:48:33Z

viewing_party/party.py

+    user_watched_titles = set()
+
+    user_watched_titles = [movie['title'] for movie in user_data.get('watched', [])]


Is there a reason why this was declared as a set and then converted into a list? I would actually say to keep it as a set since it could improve the efficiency of your code.

fixed and pushed!

mikellewade · 2024-10-03T19:51:19Z

viewing_party/party.py

+    recommended_movies = [movie for movie in friends_unique_movies 
+                          if movie['host'] in user_subscriptions 
+                          and movie['title'] not in user_watched_titles 
+                          if movie not in recommended_movies]


I think that this is a good example of maybe opting to not us list comprehension, you lose out on readability here. Even though not using comprehension takes us a little longer to type out, both ways function the same. We would re-gain the loss readability we lost here.

fixed and pushed!

mikellewade · 2024-10-08T16:39:06Z

viewing_party/party.py

+def get_new_rec_by_genre(user_data):
+    most_watched_genre = get_most_watched_genre(user_data)
+
+    recommended_movie = [movie for movie in get_friends_unique_watched(user_data) 
+                         if movie["genre"] == most_watched_genre]
+
+    return recommended_movie


Nice work, the only amendment I might ofter is to have result of get_friends_unique_watched assigned to a variable for readability.

fixed and pushed!

mikellewade · 2024-10-08T16:40:04Z

viewing_party/party.py

+    recommended_movie = [movie for movie in user_data["favorites"] 
+                         if movie["title"] not in my_friends_watched]


Love the use of a set here! Gives you a constant look up time!

mikellewade · 2024-10-08T16:41:15Z

tests/test_wave_01.py

+    assert updated_data == {
+        "watchlist": [],
+        "watched": [{
+            "title": MOVIE_TITLE_1,
+            "genre": GENRE_1,
+            "rating": RATING_1
+        }]
+    }


mikellewade · 2024-10-08T16:41:38Z

tests/test_wave_01.py

+    assert updated_data == {
+        "watchlist": [
+            FANTASY_1
+        ],
+        "watched": [FANTASY_2, HORROR_1]
+    }


mikellewade · 2024-10-08T16:44:27Z

tests/test_wave_05.py

+    recommendations = get_new_rec_by_genre(sonyas_data)
+
+     # Assert
+    assert recommendations == []


mikellewade

Great work, everyone! Feel free to reach out to me if you have any questions the feedback I left!

dpchengmath and others added 19 commits September 23, 2024 14:48

first wave 1 completed with tests passing (still need to work on exce…

7ba7fd2

…ptions)

wave 2 updates

246fd1c

wave_01 tests completed

fc6d416

updates...

57563d8

clean-up

926bc60

variable name changes

abbeea3

completed waves 1-3 but wave 3 tests still need updates and bug fixes

af9e4bc

test git

9adbfd5

merge the solution to wave 4

3a01d0b

merging changes to wave 4

f292115

debug wave 03 completed with all tests passed

eae9433

merge conflict

1a29187

mergy conflict 02

df24496

completed wave 5 and tests

53b6dd1

clean version with all five waves and tests completed

c647610

refactored version of viewing party with final edits completed.

686668a

review and clean up

8327ae5

clean version

d06e1d8

Merge branch 'main' of https://github.com/dpchengmath/viewing-party

a189a7a

shiyinxi changed the title ~~Sphinx-Lorraine Shi~~ Sphinx-Denise-Aja-Lorraine Sep 26, 2024

shiyinxi changed the title ~~Sphinx-Denise-Aja-Lorraine~~ Sphinx-Denise-Ajar-Lorraine Sep 26, 2024

shiyinxi and others added 6 commits September 27, 2024 11:24

update wave5 get_new_rec_by_genre function

8673bfd

comment out some unneccessary lines

4c9d0a5

dry edits

5fabc62

Merge branch 'main' of https://github.com/dpchengmath/viewing-party

f7c20f2

viewing party D.R.Y.

a172076

Lines under 80 characters

5f06977

mikellewade reviewed Oct 3, 2024

View reviewed changes

mikellewade reviewed Oct 8, 2024

View reviewed changes

tests/test_wave_05.py

recommendations = get_new_rec_by_genre(sonyas_data)

# Assert

assert recommendations == []

Copy link

mikellewade Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

mikellewade reviewed Oct 8, 2024

View reviewed changes

dpchengmath added 3 commits October 8, 2024 13:38

Updated viewing party

0071385

Refactoring viewing party.

50f08fe

Cleaning up viewing party file

cd1f239

		new_movie_info = {"title": title, "genre": genre, "rating": rating}
		return new_movie_info

		my_friends_unique = [movie["title"] for my_friends in user_data["friends"]
		for movie in my_friends["watched"]]

		my_unique_movies = [movie for movie in user_data["watched"]
		if movie["title"] not in my_friends_unique]

		user_watched_titles = set()

		user_watched_titles = [movie['title'] for movie in user_data.get('watched', [])]

		recommended_movie = [movie for movie in user_data["favorites"]
		if movie["title"] not in my_friends_watched]

Sphinx-Denise-Ajar-Lorraine #1

Are you sure you want to change the base?

Sphinx-Denise-Ajar-Lorraine #1

Uh oh!

Conversation

shiyinxi commented Sep 25, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpchengmath Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpchengmath Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikellewade Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpchengmath Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpchengmath Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpchengmath Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpchengmath Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikellewade left a comment

Choose a reason for hiding this comment

Uh oh!

dpchengmath Oct 8, 2024 •

edited

Loading

dpchengmath Oct 8, 2024 •

edited

Loading

mikellewade Oct 3, 2024 •

edited

Loading

dpchengmath Oct 8, 2024 •

edited

Loading

dpchengmath Oct 8, 2024 •

edited

Loading

dpchengmath Oct 8, 2024 •

edited

Loading

dpchengmath Oct 8, 2024 •

edited

Loading