Tatiana-Lorraine-C22-Sphinx #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/routes.py
Outdated
Comment on lines
17
to
21
| try: | ||
| planet_id = int(planet_id) | ||
| except: | ||
| response = {"messange" : f"planet id {planet_id} is invalid"} | ||
| abort(make_response(response, 400)) |
There was a problem hiding this comment.
We could avoid the need to use try ... except block here by specifying a converter in the URL like this:
@planet_bp.get("/<planet_id>")But in order to follow the instructions of the lesson, we kept the try ... except block here.
mikellewade
reviewed
Nov 12, 2024
| class Planet(db.Model): | ||
| id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) | ||
| name: Mapped[str] | ||
| description: Mapped[str] = mapped_column(nullable=True) |
There was a problem hiding this comment.
Its more preferred to use Optional here instead of nullable. https://docs.sqlalchemy.org/en/20/orm/declarative_tables.html#using-annotated-declarative-table-type-annotated-forms-for-mapped-column
Comment on lines
+33
to
+43
| allowed_sort_fields = { | ||
| "name": Planet.name, | ||
| "radius_in_mi": Planet.radius_in_mi, | ||
| } | ||
|
|
||
| sort_param = request.args.get("sort") | ||
| if sort_param: | ||
| sort_param = sort_param.split(" ") | ||
| # Selects the field for sorting based on the user's input (`sort_param[0]`). | ||
| # If no valid sort field is specified, defaults to sorting by Planet.id. | ||
| sort_field = allowed_sort_fields.get(sort_param[0].lower(), Planet.id) |
There was a problem hiding this comment.
Now that we know about hasattr and getattr, how could this be rewritten?
Comment on lines
+63
to
+67
| request_body = request.get_json() | ||
|
|
||
| planet.name = request_body["name"] | ||
| planet.description = request_body["description"] | ||
| planet.radius_in_mi = request_body["radius_in_mi"] |
There was a problem hiding this comment.
Could this be its own helper function?
Comment on lines
+75
to
+79
| planet = validate_model(Planet, planet_id) | ||
| db.session.delete(planet) | ||
| db.session.commit() | ||
|
|
||
| return Response(status=204, mimetype="application/json") |
Comment on lines
+83
to
+87
| request_body = request.get_json() | ||
| for planet_data in request_body["planets"]: | ||
| create_planet_helper(planet_data) | ||
|
|
||
| return Response(status=201, response="Planets have been created!", mimetype="application/json") |
Comment on lines
+94
to
+97
| return Response( | ||
| status=200, | ||
| response=f"All {num_rows_deleted} planets have been deleted!", | ||
| mimetype="application/json") |
There was a problem hiding this comment.
This could also be done with a regular dictionary.
| db.session.add(new_planet) | ||
| db.session.commit() | ||
|
|
||
| return new_planet |
Comment on lines
+31
to
+50
| @pytest.fixture | ||
| def client(app): | ||
| return app.test_client() | ||
|
|
||
| @pytest.fixture | ||
| def two_saved_planets(app): | ||
| # Arrange | ||
| Mercury = Planet( | ||
| name="Mercury", | ||
| description="about 1/3 the size of Earth", | ||
| radius_in_mi=1.516 | ||
| ) | ||
| Venus = Planet( | ||
| name="Venus", | ||
| radius_in_mi=3.760, | ||
| description="only slightly smaller than Earth" | ||
| ) | ||
|
|
||
| db.session.add_all([Mercury, Venus]) | ||
| db.session.commit() |
| "name": "Earth", | ||
| "description": "Earth itself", | ||
| "radius in miles" : 3.959 | ||
| } |
| # cause an `HTTPException` when an `abort` statement is reached | ||
| with pytest.raises(HTTPException): | ||
| result_Planet = validate_model(Planet, "cat") | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.