C22 Phoenix - Tatyana Venanzi #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| let hand = []; | ||
| for (let i = 0; i < 10; i++) { |
There was a problem hiding this comment.
This loop declares a variable i, but we never use that variable inside the loop. A while loop that runs until the hand array has 10 elements might be a better fit.
Comment on lines
+63
to
+70
| for (const letter of upperCaseInput) { | ||
| if (copyLettersInHand.includes(letter)) { | ||
| const index = copyLettersInHand.indexOf(letter); | ||
| copyLettersInHand.splice(index,1); | ||
| } else { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
This implementation has an O(n^2) time complexity, how could we use a frequency map to bring the time complexity down to O(n)?
| }; | ||
|
|
||
| export const usesAvailableLetters = (input, lettersInHand) => { | ||
| // Implement this method for wave 2 | ||
| const copyLettersInHand = [...lettersInHand]; |
There was a problem hiding this comment.
Nice use of the spread operator to copy lettersInHand!
| for (const letter of word) { | ||
| totalScore += LETTER_SCORES[letter] || 0; | ||
| } | ||
| return totalScore += word.length >= 7 ? 8 : 0; //ternary expression |
There was a problem hiding this comment.
Love a good ternary expression ^_^
I would recommend removing the comment at the end or reframing it to describe the purpose of this ternary expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.