Lions - Jessica A. #115
Open
Lions - Jessica A. #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alope107
reviewed
Feb 17, 2023
Comment on lines
+1
to
+7
| { | ||
| "python.testing.pytestArgs": [ | ||
| "node_modules" | ||
| ], | ||
| "python.testing.unittestEnabled": false, | ||
| "python.testing.pytestEnabled": true | ||
| } No newline at end of file |
There was a problem hiding this comment.
I don't think these are correct settings - we're not using Python. Also, your individual VS Code settings should not be committed. They should be added to the .gitignore if needed.
| import ChatLog from './components/ChatLog'; | ||
|
|
||
| const App = () => { | ||
| const [chatLogList, setchatLogList] = useState([]); |
There was a problem hiding this comment.
The state should start from the chatMessages, not empty.
| <h1>Application title</h1> | ||
| </header> | ||
| <main> | ||
| <ChatLog chatLogList={chatMessages} /> |
There was a problem hiding this comment.
This should be using the state instead of the messages directly
Comment on lines
7
to
+10
| const ChatEntry = (props) => { | ||
| const sender = props.sender; | ||
| const senderBody = props.body; | ||
| const timeStamp = props.timeStamp; |
There was a problem hiding this comment.
In the future consider destructuring props in the constructor.
| const sender = props.sender; | ||
| const senderBody = props.body; | ||
| const timeStamp = props.timeStamp; | ||
| const [isLiked, setIsLiked] = useState(false); |
There was a problem hiding this comment.
This type of state should be lifted up
Comment on lines
+24
to
+34
| ChatLog.propTypes = { | ||
| chatLogList: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| id: PropTypes.number.isRequired, | ||
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool.isRequired, | ||
| }) | ||
| ), | ||
| }; |
There was a problem hiding this comment.
Make sure to make the overall array prop as required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.