Tigers- Selam Chaka #60
Conversation
| if letter_freq[letter] <= LETTER_POOL[letter]: | ||
| selected_letters.append(letter) | ||
| return (selected_letters[0:10]) | ||
|
|
There was a problem hiding this comment.
This looks good, overall but remember that it is not accounting for the different probabilities of each letter! We could take that into account by creating a collection of some sort that holds every possible value (12 E's, 9 A's, etc) and then making our selections from that collection and removing them as they are picked!
| elif temp_word != word: | ||
| return False | ||
| elif temp_word == word: | ||
| return True |
There was a problem hiding this comment.
I see exactly what y'all were doing here. The problem is that you are making a variety of extra dictionaries and strings that just aren't necessary. In cases like this, it would be much better to make a deep copy of the letter_bank. From there, you can simply manipulate your copy.
The process would be as follows:
- Make a deep copy of the letter bank.
- Go through each letter in the word and see if it is in the letter bank copy.
a) If it is, remove it from the letter bank copy.
b) If it isn't return False - If you make it through the word without returning False, return True.
This will take into account multiples of the same letter!
| elif temp_word != word: | ||
| return False | ||
| elif temp_word == word: | ||
| return True |
There was a problem hiding this comment.
I see exactly what y'all were doing here. The problem is that you are making a variety of extra dictionaries and strings that just aren't necessary. In cases like this, it would be much better to make a deep copy of the letter_bank. From there, you can simply manipulate your copy.
The process would be as follows:
- Make a deep copy of the letter bank.
- Go through each letter in the word and see if it is in the letter bank copy.
a) If it is, remove it from the letter bank copy.
b) If it isn't return False - If you make it through the word without returning False, return True.
This will take into account multiples of the same letter!
| score_word += 8 | ||
|
|
||
| return score_word | ||
|
|
There was a problem hiding this comment.
This looks great! It's a simple and effective implementation of the score method!
|
|
||
| return (highest_word, highest_value) | ||
|
|
There was a problem hiding this comment.
Once again, you are creating several extra lists that we don't necessarily need. This works and is a great first pass, but we could definitely pare it down a bit! One implementation would have been to have a tuple that just holds the highest scoring word and the highest score. From there, we can do the following:
- Make a tuple to hold the first word and its score.
- For each word in the list, score it and compare it to the score in your highest word tuple.
- If the score is higher, replace the tuple with the new word.
- If it is a tie, run the if/else statements you have there toward the bottom of the function!
This really just avoids having to write a tie_word list. We can kind of figure out what the highest word in place.
Completed waves.