Leaves - Katie #45
Open
Leaves - Katie #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Nov 5, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, take a look at my comments regarding time complexity. Also could you reuse 1 method to do the reverse on individual words?
| return string | ||
| end | ||
|
|
||
| def word_reverse(string) |
| return my_sentence | ||
| end | ||
|
|
||
| def string_reverse(string) |
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # A method to reverse the words in a sentence, in place. | ||
| # Time complexity: O(n^3) |
There was a problem hiding this comment.
This is actually O(n) as a solution.
Comment on lines
+40
to
+47
| while word_start < word_end do | ||
| temp_i = string[word_start] | ||
| temp_j = string[word_end] | ||
| string[word_start] = temp_j | ||
| string[word_end] = temp_i | ||
| word_start+=1 | ||
| word_end-=1 | ||
| end |
There was a problem hiding this comment.
This does the same logic as reverse_sentence, so why not make the method flexible enough to be used in both places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting & Reverse Sentence