Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions lib/fibonacci.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,25 @@
# Improved Fibonacci

# Time Complexity - ?
# Space Complexity - ? (should be O(n))
# Time Complexity - O(n)
# Space Complexity - O(n)
# Hint, you may want a recursive helper method
def fibonacci(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but you're keeping the entire list of fibonacci numbers for the whole length of the recursion.  Instead you should only keep the last 2 fibonacci numbers.


if n < 0
raise ArgumentError
end
return fib_helper(n, {})
end

def fib_helper(n, hash)
if hash.key? n
return hash[n]
end

# basecase
if n == 0 || n == 1
return n
end

hash[n] = fib_helper(n - 1, hash) + fib_helper(n - 2, hash)
return hash[n]
end
29 changes: 19 additions & 10 deletions lib/super_digit.rb
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
# Superdigit

# Time Complexity - ?
# Space Complexity - ?
# Time Complexity - O(n)
# Space Complexity - O(1)
Comment on lines +3 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time & Space O(log10n)

def super_digit(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


end
s = n.to_s
if s.length <= 1 # basecase here
return n
end


# Time Complexity - ?
# Space Complexity - ?
def refined_super_digit(n, k)

sum = 0
s.split("").each do |d|
sum += d.to_i
end

return super_digit(sum)
end



# # Time Complexity - ?
# # Space Complexity - ?
# def refined_super_digit(n, k)

# end
4 changes: 2 additions & 2 deletions test/super_digit_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "super_digit" do
describe "super_digit" do
it "will return 2 for super_digit(9875)" do
# Act
answer = super_digit(9875)
Expand Down Expand Up @@ -33,7 +33,7 @@
expect(answer).must_equal 6
end

describe "refined superdigit" do
xdescribe "refined superdigit" do
it "will return 1 for n = 1 and k = 1" do
# Act
answer = refined_super_digit(1, 1)
Expand Down