Skip to content

Leaves - Julia K #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Leaves - Julia K #43

wants to merge 11 commits into from

Conversation

@Kalakalot
Copy link

@Kalakalot Kalakalot commented Dec 16, 2019

Exquisite React

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How did this project differ from in-class examples? Using a conditional to determine which content is rendered was new to me!
How was this project similar to in-class examples? The form field setup and validation was very close to in-class examples (thankfully)
If you had time to refactor one part of this project, what would you do to make it better? I would DRY up the conditional formatting in the input fields so there aren't six different validation functions.

Julia A Kingrey added 11 commits December 15, 2019 11:26
Planning and notes for how data will be passed around app.
97fb904
Adding player input fields.
ae67c55
Adding receptacles for current line and final poem and added articles…
3b00558 
… to player submission form.
Capturing submitted input and passing it to game via addLine.
7c5140b
Adding recent submission line
f02bb0f
Incrementing player number.
c8fae99
Refactoring input fields to incorporate pattern we learned in class. …
668b1af 
…Now fields reset after submit button is pressed.
Displaying final poem but need to adjust form to match deployed example.
02abd3f
Adding if/else statement that removes recent submission and player su…
3ca1424 
…bmission form when final poem is displayed. Unlike the example version, my code removes the game instructions when the final poem is revealed but I assert that this is an intentional design choice
Applying conditional formatting for input fields. It ain't concise bu…
51d2090 
…t it works.
Cleaned up notes and removed console.log statements. Leaving notes in…
8b5b677 
… because I find it helpful to refer to them down the line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Kalakalot