Skip to content

Branches - Angele #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Branches - Angele #42

wants to merge 1 commit into from

Conversation

geli-gel
Copy link

@geli-gel geli-gel commented Aug 7, 2019

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? What went well was indentation, I feel like it is readable and I often rename variables to try to make them clear. Sometimes maybe they are too long of names! Lacking was my description of what my first case-when block was doing, I was trying to explain it to Sara and realized I should have left a comment - fixed that. But should have been commenting it better.
How did your code keep track of user input? My code kept track of user input by storing each necessary part in its own variable.
How did your code determine what operation to perform? My code determined what operation to perform by using a case-when-else conditional within an until loop to keep asking for input until one of the options was chosen, then storing the chosen math operation as a string of the actual ruby arithmetic method to use later with .send.
What opportunities exist to create small methods for this project? I thing a good method would be method to display the answers. I used a method to check for number validity
In the next project, what would you change about your process? What would you keep doing? Something I would change about my process is spending too much time figuring out how to use regex when I didn't even end up using it. I need to google search for what I'm trying to solve and not go too far down rabbit holes. I think the pseudocode worked well to get my head in the right mindset to keep thinking about different options and ways of going. Also I think I might keep looking at the optional features to help think about how to design my code because if I hadn't it might have been hard to alter later on.

@jmaddox19
Copy link

Calculator

What We're Looking For

Feature Feedback
Readable code with consistent indentation X
Practices using variables appropriately X
Practices using conditionals appropriately X
If any, practices iteration appropriately X
If any, practices using custom methods appropriately X
Takes in two numbers and an operator and can perform addition X
Takes in two numbers and an operator and can perform subtraction X
The program handles divide when attempting to divide by zero X

Great job!

It can be so hard to avoid the rabbit holes when coding! Such a good skill though. I find myself doing that often myself. I love that you're already working to be aware and sharpen that skill.

Your code is very clean, readable and functional, with extra functionality!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants