Skip to content

Branches - Emily Ball #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Branches - Emily Ball #38

wants to merge 1 commit into from

Conversation

eaball35
Copy link

@eaball35 eaball35 commented Aug 7, 2019

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? Well: Code works, relatively well organized, not too much repetition, ability to scale Lacking: number validation doesn't work for '9bananas', could use eval() instead of when case to calculate using operator symbol to simplify
How did your code keep track of user input? operator variable and numbers array
How did your code determine what operation to perform? checked value in hash of operators with possible options - assigned standard operator to operator after checking if input is eligible
What opportunities exist to create small methods for this project? Method for the error message, method for the displayed results, method for getting numbers from user
In the next project, what would you change about your process? What would you keep doing? I would save multiple version of my file as I go. As I tried to make it more complicated, I lost previous less complicated but working versions of the program. I would keep iterating on the program starting with hitting the basic requirements and then building in other features.

@eaball35 eaball35 changed the title Create calculator.rb Branches - Emily Aug 7, 2019
@eaball35 eaball35 changed the title Branches - Emily Branches - Emily Ball Aug 7, 2019
@jmaddox19
Copy link

Calculator

What We're Looking For

Feature Feedback
Readable code with consistent indentation X
Practices using variables appropriately X
Practices using conditionals appropriately X
If any, practices iteration appropriately X
If any, practices using custom methods appropriately X
Takes in two numbers and an operator and can perform addition X
Takes in two numbers and an operator and can perform subtraction X
The program handles divide when attempting to divide by zero X

I love the use of lists nested within a hash for the operators! Also very cool that you made a loop to print out all the possible operators!

I want to let you know that we will learn about git early next week, which was created to help with your problem of going back to previous working versions!

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants