Branches - Michaela

[michaela260]

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking?	I think that my indentation and spacing worked well and that the code is generally readable. I am still hoping to improve my comments to know which are necessary and unnecessary for user readability and best practices. Also, some of my comments are a bit long.
How did your code keep track of user input?	The code stored user input in the specified variables chosen_operator and chosen_number. New values were assigned to these variables when the user submitted updated input (after an invalid input, for example).
How did your code determine what operation to perform?	The program determined which operation to perform by using the "send" method to interpret a string such as "+" or "-" as a method rather than string. The code handled written operators (i.e. "plus" or "minus") by linking each of these to their corresponding operator (+, -, etc.) in a key-value pair within the hash "operators."
What opportunities exist to create small methods for this project?	You could define a method for each operator (multiply divide, etc.) and then use case/when to call the given method for each set of input string operators. You could also create methods for each type of error request, and a method to display the valid user input options (valid operators).
In the next project, what would you change about your process? What would you keep doing?	In the next project, I would complete the basic requirements before delving deep into rabbit holes of multiple possible solutions. I think I would spend a bit less time trying to make multiple solutions work and instead do that at the end if I have extra time. I would continue to experiment with using new methods and types of code that I have not tried before because it was good practice.

[tildeee]

Calculator

What We're Looking For

Feature	Feedback
Readable code with consistent indentation	x
Practices using variables appropriately	x
Practices using conditionals appropriately	x
If any, practices iteration appropriately	x
If any, practices using custom methods appropriately	x
Takes in two numbers and an operator and can perform addition	x
Takes in two numbers and an operator and can perform subtraction	x
The program handles divide when attempting to divide by zero	x

Fantastic work on this project, Michaela! Your solutions are so well-organized, clever, logical, and readable. I really really really like the specific methods you pulled out for this assignment.

I have a few comments and suggestions on how I might push this assignment for more refactoring if you had more time on it-- mostly, some ways to refactor those methods.

However, overall this was a great project submission. Great work!

[tildeee]

The error_message_operators method is so so so clever. I like it a lot! Keep doing things like this! It may be interesting to rename this method to something like get_operator, and refactor the code so that you only pass in operators (instead of chosen_operator and operators) and also get the initial user operator in the method, too. For example, consider:

def get_operator(valid_input)
  input = gets.chomp.downcase
  until valid_input.keys.include? input.to_sym
    puts "Oops! Your input was invalid. Your options are:"
    print_operators
    input = gets.chomp
  end
  return input
end

[tildeee]

Similar to my suggestion above, it may be interesting to refactor to a name like get_number, and that method could change to

def error_message_numbers
  input = Float(gets) rescue nil
  while input == nil
    puts "Oops! Your input was invalid. Please enter a number: "
    input = Float(gets) rescue nil
  end
  return input
end

[tildeee]

this solution RULES! In practicality, I hope that you are never in a work situation where you will realistically need to use .send, because that's a dangerous method! But for this specific case, it ends up being perfect. Well done, and nice work combining it with your operators lookup hash.

[tildeee]

I love this method!!