Skip to content

Branches - Erika #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Branches - Erika #30

wants to merge 1 commit into from

Conversation

emaust
Copy link

@emaust emaust commented Aug 7, 2019

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? I think my indentation has improved from previous assignments, but I could definitely be using better commenting and more meaningful variable names (eg. o_array isn't great)
How did your code keep track of user input? it was assigned to a variable
How did your code determine what operation to perform? I used case/when syntax to identify which operation was entered by the user, then used string interpolation to both calculate and display the result using the user's operation
What opportunities exist to create small methods for this project? Despite not using any, I think that methods could have been created for displaying user output and for performing the requested operation.
In the next project, what would you change about your process? What would you keep doing? I would work more specifically on creating my own methods, and creating a more concise code. Unless I receive feedback indicating otherwise, I think my code is easily readable and would continue commenting and breaking up the code the way that I have

@jmaddox19
Copy link

Calculator

What We're Looking For

Feature Feedback
Readable code with consistent indentation X
Practices using variables appropriately X
Practices using conditionals appropriately X
If any, practices iteration appropriately X
If any, practices using custom methods appropriately N/A
Takes in two numbers and an operator and can perform addition X
Takes in two numbers and an operator and can perform subtraction X
The program handles divide when attempting to divide by zero X

Great job! I totally agree with you! The code is clean, readable, and fully functional!

It was definitely not necessary to create methods to effectively complete this assignment and you'll get plenty of practice with that moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants