Skip to content

Branches - Diana Han #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Branches - Diana Han #29

wants to merge 1 commit into from

Conversation

dhan0406
Copy link

@dhan0406 dhan0406 commented Aug 7, 2019

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? I think my variables were named appropriately for good readability. I think I could improve on my commenting practices as well as spacing.
How did your code keep track of user input? I assigned each user input to its own variable: operation, num1, num2.
How did your code determine what operation to perform? I used the case/when syntax to check which operation to perform based on the value of variable operation.
What opportunities exist to create small methods for this project? I created a method check_number to verify if the user input is a valid number.
In the next project, what would you change about your process? What would you keep doing? I would keep the case/when syntax but would like to create more methods to implement further optional enhancements. Also, I want to come up with another conditional statement besides regex to check for a valid integer/float. (ex. while using regex, an input of 9banana is accepted as a number 9.)

@jmaddox19
Copy link

Calculator

What We're Looking For

Feature Feedback
Readable code with consistent indentation X
Practices using variables appropriately X
Practices using conditionals appropriately X
If any, practices iteration appropriately X
If any, practices using custom methods appropriately X
Takes in two numbers and an operator and can perform addition X
Takes in two numbers and an operator and can perform subtraction X
The program handles divide when attempting to divide by zero X

Great job! Code is very easy to read and I love the added option to replay without needing to restart the program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants