Michelle - Edges - Calculator #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalculatorWhat We're Looking For
Great job overall! This code works well, and I really like the way you use methods to break up your code - this makes it much easier to read than it would be otherwise. You also make good use of whitespace to separate different ideas. Keep up the hard work! |
| def checks_input_operator(operator_choice) | ||
| while operator_choice != "ADD" && operator_choice != "+" && operator_choice != "SUBTRACT" && operator_choice != "-" && operator_choice != "MULTIPLY" && operator_choice != "*" && operator_choice != "DIVIDE" && operator_choice != "/" && operator_choice != "MODULO" && operator_choice != "%" && operator_choice != "EXPONENT" && operator_choice != "^" | ||
| puts inserts_blank_line() | ||
| puts "Oops! Your entry was invalid. Please try again." |
There was a problem hiding this comment.
I like that you've broken all of these out into their own methods - that makes the driver code below very easy to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions