Fix ImportError when using newer Flask version #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c6554ac in 7 seconds
More details
- Looked at
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. aw_server/custom_static.py:30
- Draft comment:
The import ofescapefrommarkupsafeis correct and aligns with Flask 2.3.0 changes. - Reason this comment was not posted:
Confidence changes required:0%
The PR correctly replaces the deprecated import ofescapefrom Flask with the import frommarkupsafe. This aligns with the changes in Flask 2.3.0.
Workflow ID: wflow_6Puptlz7Gr5fMtRf
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
yep, just did this on my AUR install (activitywatch-bin), seems aw-server hasn't been working because of it this whole time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
escapeis deprecated after Flask 2.3.0.Important
Replace deprecated
escapeimport fromflaskwithmarkupsafeincustom_static.py.escapeimport fromflaskwithmarkupsafeincustom_static.py.This description was created by
for c6554ac. It will automatically update as commits are pushed.