Skip to content

Conversation

zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Aug 17, 2025

@zjb0807 zjb0807 requested a review from xlc August 17, 2025 13:09
gas_limit,
storage_limit,
access_list.into_iter().map(|v| (v.address, v.storage_keys)).collect(),
vec![], // TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this? is this needs to be done now or later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-ethereum/evm#323
It's EIP-7702, the pallet call needs to be changed, so it has not been updated yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok can you make an issue and reference it

@zjb0807 zjb0807 mentioned this pull request Aug 18, 2025
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 41.90141% with 165 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.82%. Comparing base (069ed19) to head (ddfc7b8).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
modules/transaction-payment/src/lib.rs 51.72% 56 Missing ⚠️
modules/evm/src/runner/stack.rs 45.09% 28 Missing ⚠️
primitives/src/unchecked_extrinsic.rs 0.00% 27 Missing ⚠️
modules/evm/src/runner/state.rs 35.00% 26 Missing ⚠️
modules/evm/src/lib.rs 35.00% 13 Missing ⚠️
modules/xnft/src/xcm_helpers.rs 0.00% 7 Missing ⚠️
primitives/src/currency.rs 20.00% 4 Missing ⚠️
modules/assethub/src/lib.rs 0.00% 2 Missing ⚠️
modules/evm/src/precompiles/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2906      +/-   ##
==========================================
- Coverage   61.12%   60.82%   -0.30%     
==========================================
  Files          69       69              
  Lines        9449     9586     +137     
==========================================
+ Hits         5776     5831      +55     
- Misses       3673     3755      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xlc xlc merged commit f51f175 into master Sep 24, 2025
6 of 7 checks passed
@xlc xlc deleted the polkadot-stable2503 branch September 24, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants