Skip to content

Fix spec and host support lib to return proper val for host type #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix spec and host support lib to return proper val for host type #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Documentation/sources/Reference/ofxPropertiesByObject.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ Properties on the Image Effect Host
- kOfxPropAPIVersion
- (read only) the version of the API implemented by the host. If not present, it is safe to assume "1.0"
- kOfxPropType
- (read only) set to "host"
- (read only) type of the object. Set to kOfxTypeImageEffectHost
- kOfxPropName
- (read only) the globally unique name of the application, eg: "com.acmesofware.funkyCompositor"
- kOfxPropLabel
- (read only) the user visible name of the appliaction,
- (read only) the user visible name of the application
- kOfxPropVersion
- (read only) the version number of the host
- kOfxPropVersionLabel
Expand Down
2 changes: 1 addition & 1 deletion HostSupport/src/ofxhHost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ namespace OFX {

static const Property::PropSpec hostStuffs[] = {
{ kOfxPropAPIVersion, Property::eInt, 0, false, "" },
{ kOfxPropType, Property::eString, 1, false, "Host" },
{ kOfxPropType, Property::eString, 1, false, kOfxTypeImageEffectHost },
{ kOfxPropName, Property::eString, 1, false, "UNKNOWN" },
{ kOfxPropLabel, Property::eString, 1, false, "UNKNOWN" },
{ kOfxPropVersion, Property::eInt, 0, false, "0" },
Expand Down
3 changes: 3 additions & 0 deletions release-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ This is version 1.6 of the OpenFX API.

## Fixes in OpenFX Version 1.6:

- Clarify that Image Effect Hosts property `kOfxPropType` must have the value
`kOfxTypeImageEffectHost`, and fix host support lib to implement that.

## Deprecations

## Detailed List of Changes
Expand Down
Loading