refactor: explicitly type EIP-712 transactions in signTransaction #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the signEip712TransactionInternal function to explicitly type transactions as TransactionRequestEIP712 to improve type safety and clarity when working with EIP-712 transactions.
PR-Codex overview
This PR enhances the
signEip712TransactionInternal
function by explicitly typing the transaction asTransactionRequestEIP712
, allowing for clearer handling of EIP-712 transactions and improving type safety.Detailed summary
transaction
variable is explicitly typed asTransactionRequestEIP712 & { type: 'eip712' }
.transaction.type
is replaced witheip712Transaction.type
.from
property check is updated to useeip712Transaction
.assertEip712Request
call now spreadseip712Transaction
instead oftransaction
.getTransactionWithPaymasterData
now useseip712Transaction
instead oftransaction
.