Skip to content

Conversation

crStiv
Copy link

@crStiv crStiv commented Aug 5, 2025

Refactors the signEip712TransactionInternal function to explicitly type transactions as TransactionRequestEIP712 to improve type safety and clarity when working with EIP-712 transactions.


PR-Codex overview

This PR enhances the signEip712TransactionInternal function by explicitly typing the transaction as TransactionRequestEIP712, allowing for clearer handling of EIP-712 transactions and improving type safety.

Detailed summary

  • The transaction variable is explicitly typed as TransactionRequestEIP712 & { type: 'eip712' }.
  • The assignment of transaction.type is replaced with eip712Transaction.type.
  • The from property check is updated to use eip712Transaction.
  • The assertEip712Request call now spreads eip712Transaction instead of transaction.
  • The call to getTransactionWithPaymasterData now uses eip712Transaction instead of transaction.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Aug 5, 2025

⚠️ No Changeset found

Latest commit: 804b1d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant