Skip to content

Conversation

coffeexcoin
Copy link
Collaborator

@coffeexcoin coffeexcoin commented May 23, 2025

PR-Codex overview

This PR introduces support for optimistic transaction parameters in the agw-client, enhancing transaction efficiency by reducing RPC calls and adding new types and interfaces for optimistic transactions.

Detailed summary

  • Updated .editorconfig to include ts file type.
  • Added optimistic transaction parameters to signTransactionForSession.
  • Introduced OptimisticTransactionParameters interface and DefaultOptimisticTransactionParameters.
  • Modified sendTransactionInternal to handle optimistic data.
  • Updated tests to reflect changes in transaction handling.
  • Refactored related functions to support optimistic transaction features.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: d408dc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@abstract-foundation/agw-client Minor
@abstract-foundation/agw-react Patch
@abstract-foundation/agw-web Patch
@abstract-foundation/web3-react-agw Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 23, 2025

Codecov Report

❌ Patch coverage is 65.45455% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ages/agw-client/src/types/optimisticTransaction.ts 0.00% 7 Missing and 1 partial ⚠️
...gw-client/src/actions/signTransactionForSession.ts 0.00% 5 Missing ⚠️
...kages/agw-client/src/actions/prepareTransaction.ts 75.00% 4 Missing ⚠️
packages/agw-client/src/exports/experimental.ts 0.00% 0 Missing and 1 partial ⚠️
packages/agw-client/src/walletActions.ts 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
.../agw-client/src/actions/sendTransactionInternal.ts 79.71% <100.00%> (-15.23%) ⬇️
packages/agw-client/src/actions/signTransaction.ts 87.36% <100.00%> (+0.48%) ⬆️
packages/agw-client/src/exports/experimental.ts 0.00% <0.00%> (ø)
packages/agw-client/src/walletActions.ts 68.31% <0.00%> (ø)
...kages/agw-client/src/actions/prepareTransaction.ts 85.02% <75.00%> (-1.28%) ⬇️
...gw-client/src/actions/signTransactionForSession.ts 11.90% <0.00%> (-0.87%) ⬇️
...ages/agw-client/src/types/optimisticTransaction.ts 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coffeexcoin coffeexcoin changed the title [WIP] experimental feat: add optimistic transaction parameters to sign/send transaction Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant