Skip to content

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 1, 2025

Remove unnecessary includes in the generated code. Reduces serial compilation time by a second or two.

@dweindl dweindl self-assigned this Oct 1, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.98%. Comparing base (dcbbae0) to head (ee92c5c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2953      +/-   ##
==========================================
- Coverage   76.60%   75.98%   -0.62%     
==========================================
  Files         307      307              
  Lines       20134    20140       +6     
  Branches     1553     1553              
==========================================
- Hits        15423    15304     -119     
- Misses       4698     4823     +125     
  Partials       13       13              
Flag Coverage Δ
cpp 72.18% <100.00%> (+0.05%) ⬆️
cpp_python 37.93% <100.00%> (+0.01%) ⬆️
petab 38.99% <100.00%> (+0.02%) ⬆️
python 69.82% <100.00%> (+0.06%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/abstract_model.h 100.00% <ø> (ø)
include/amici/model.h 71.42% <ø> (ø)
python/sdist/amici/_codegen/cxx_functions.py 97.14% <100.00%> (+0.59%) ⬆️
python/sdist/amici/de_export.py 97.16% <100.00%> (ø)
src/abstract_model.cpp 4.28% <ø> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review October 1, 2025 08:55
@dweindl dweindl requested a review from a team as a code owner October 1, 2025 08:55
Remove unnecessary includes in the generated code. Reduces serial compilation time by a second or two.
@dweindl dweindl added this pull request to the merge queue Oct 3, 2025
Merged via the queue into AMICI-dev:main with commit 6d0402a Oct 3, 2025
23 of 24 checks passed
@dweindl dweindl deleted the opt_include branch October 3, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants