Skip to content

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 30, 2025

Mask root functions once a root was found until we encounter a negative value. Related to #2861.

WIP

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

❌ Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.53%. Comparing base (947aba7) to head (8f7aea3).
⚠️ Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
src/model_dae.cpp 0.00% 5 Missing ⚠️
include/amici/misc.h 0.00% 2 Missing ⚠️
include/amici/serialization.h 0.00% 2 Missing ⚠️
include/amici/model.h 75.00% 1 Missing ⚠️
include/amici/model_state.h 66.66% 1 Missing ⚠️
src/forwardproblem.cpp 66.66% 1 Missing ⚠️
src/model_ode.cpp 83.33% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (947aba7) and HEAD (8f7aea3). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (947aba7) HEAD (8f7aea3)
python 18 5
cpp_python 3 1
cpp 3 0
sbmlsuite-jax 3 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2862       +/-   ##
===========================================
- Coverage   80.31%   39.53%   -40.79%     
===========================================
  Files         330      330               
  Lines       22503    22529       +26     
  Branches     1514     1521        +7     
===========================================
- Hits        18073     8906     -9167     
- Misses       4419    13593     +9174     
- Partials       11       30       +19     
Flag Coverage Δ
cpp ?
cpp_python 33.74% <51.85%> (+0.02%) ⬆️
petab 39.21% <8.69%> (-0.05%) ⬇️
python 34.23% <41.66%> (-40.28%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/model.cpp 44.77% <100.00%> (-42.11%) ⬇️
include/amici/model.h 40.00% <75.00%> (-43.88%) ⬇️
include/amici/model_state.h 90.29% <66.66%> (-6.74%) ⬇️
src/forwardproblem.cpp 72.16% <66.66%> (-23.59%) ⬇️
src/model_ode.cpp 50.62% <83.33%> (-20.19%) ⬇️
include/amici/misc.h 45.65% <0.00%> (-40.72%) ⬇️
include/amici/serialization.h 0.00% <0.00%> (-95.20%) ⬇️
src/model_dae.cpp 0.00% <0.00%> (-33.92%) ⬇️

... and 240 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant